mirror of
https://github.com/AdguardTeam/AdGuardHome.git
synced 2026-03-04 00:01:12 -05:00
Query Log doesn't show date #1112
Labels
No labels
P1: Critical
P2: High
P3: Medium
P4: Low
UI
bug
cannot reproduce
compatibility
dependencies
docker
documentation
duplicate
enhancement
enhancement
external libs
feature request
good first issue
help wanted
infrastructure
invalid
localization
needs investigation
performance
potential-duplicate
question
recurrent
research
snap
waiting for data
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/AdGuardHome#1112
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Ultrabenosaurus on GitHub (Nov 24, 2019).
Originally assigned to: @ArtemBaskal on GitHub.
Prerequisites
Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.
Problem Description
Now that AGH supports logging more than 24 hours of data the Query Log should display the date as well as the time for each row, at least for any request not made on the current day. At the moment the date is only shown in a tooltip when hovering over the time no matter how wide you drag the column. In the screenshot below I have filtered the log based on the IP address of a relative's smartphone, who last visited a few days ago.
Proposed Solution
Show the date for requests not made on the current day or for all requests, with a default column width suitable for displaying both date and time. This could be enabled for all users or dynamic based on the chosen data retention period, e.g. it's not entirely necessary for people who have their AGH set to 24 hours.
Alternatives Considered
It may also be nice to have a toggle setting for "always show date" vs. "show date for requests not made today" so people can choose how they want it displayed. I can't speak for everybody but I would find it much easier to notice when I reach the end of today's data while flicking through my Query Log if one request only shows a time and the next also shows the date. This would be beneficial when looking for suspect, missing, or expected requests, or when investigating a sudden increase in requests.
@ghost commented on GitHub (Nov 24, 2019):
https://github.com/AdguardTeam/AdGuardHome/issues/624 (v0.101)
@Ultrabenosaurus commented on GitHub (Nov 24, 2019):
@ArchiveBase I feel that this is different now. #624 is about Chinese localisation and was opened before AGH could support more than 24 hours of log retention. Now the log can contain more than 24 hours this should be high priority.
I almost opened this as a bug instead of feature request as it feels like it was "missed" or "forgotten" when extended log retention was added. It's very annoying when viewing the Query Log, especially when filtering the data, that it is not obvious what day a request was made.