starred/AdGuardHome

Fork 0

mirror of https://github.com/AdguardTeam/AdGuardHome.git synced 2026-03-04 00:01:12 -05:00

Add a "Blocked by CIDR" colour/stamp distinction to the "Top Clients" statistic #1480

New issue

Closed

opened 2026-03-04 01:19:53 -05:00 by deekerman · 3 comments

deekerman commented

2026-03-04 01:19:53 -05:00

Owner

Originally created by @DandelionSprout on GitHub (Apr 14, 2020).

Prerequisites

Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

I am running the latest version (v0.101.0)
I checked the documentation and found no answer
I checked to make sure that this issue has not already been filed

Problem Description

I realised around 2 weeks ago that disallowed clients are now shown in a pink-red colour in the "Top Clients" statistic, as seen in the screencap below. This is pretty convenient, so that one doesn't spend unnecessary time on disallowing IPs that have already been blocked.

However, this does currently not occur if the IP has been disallowed by a CIDR in "Disallowed Clients". This means that 66.42.114.152 is shown as white and not blocked in "Top Clients", even if 66.42.64.0/18 is present in "Disallowed Clients" and indeed does disallow that particular IP.

Proposed Solution

That clients that have been disallowed by CIDRs, are shown in a shade of red that differs slightly from that of clients disallowed by singular IPs; and also that a "Blocked by CIDR" tag, "Unblock CIDR" button or "Unblock IP" button is shown when hovering over it.

Alternatives Considered

Whichever other way of distinguishing such CIDR-disallowed client IPs.

Additional Information

None that I'm aware of at the moment.

Originally created by @DandelionSprout on GitHub (Apr 14, 2020).  ### Prerequisites Please answer the following questions for yourself before submitting an issue. **YOU MAY DELETE THE PREREQUISITES SECTION.** - [x] I am running the latest version (v0.101.0) - [x] I checked the documentation and found no answer - [x] I checked to make sure that this issue has not already been filed ### Problem Description I realised around 2 weeks ago that disallowed clients are now shown in a pink-red colour in the "Top Clients" statistic, as seen in the screencap below. This is pretty convenient, so that one doesn't spend unnecessary time on disallowing IPs that have already been blocked. ![image](https://user-images.githubusercontent.com/22780683/79229000-a21e2200-7e62-11ea-8120-41a96521721d.png) However, this does currently *not* occur if the IP has been disallowed by a CIDR in "Disallowed Clients". This means that `66.42.114.152` is shown as white and not blocked in "Top Clients", even if `66.42.64.0/18` is present in "Disallowed Clients" and indeed does disallow that particular IP. ### Proposed Solution That clients that have been disallowed by CIDRs, are shown in a shade of red that differs slightly from that of clients disallowed by singular IPs; and also that a "Blocked by CIDR" tag, "Unblock CIDR" button or "Unblock IP" button is shown when hovering over it. ### Alternatives Considered Whichever other way of distinguishing such CIDR-disallowed client IPs. ### Additional Information None that I'm aware of at the moment.

deekerman

2026-03-04 01:19:53 -05:00

closed this issue
added the
duplicate
label

deekerman commented

2026-03-04 01:19:59 -05:00

Author

Owner

@ameshkov commented on GitHub (Apr 15, 2020):

This is possible but requires some work on the client-side to interpret disallowed CIDRs and check the IP addresses properly. However, unblocking IP, in this case, won't be possible -- excluding an IP address from a CIDR range is not a trivial task.

@ameshkov commented on GitHub (Apr 15, 2020): This is possible but requires some work on the client-side to interpret disallowed CIDRs and check the IP addresses properly. However, unblocking IP, in this case, won't be possible -- excluding an IP address from a CIDR range is not a trivial task.

deekerman commented

2026-03-04 01:20:00 -05:00

Author

Owner

@Aikatsui commented on GitHub (Oct 3, 2020):

https://github.com/AdguardTeam/AdGuardHome/issues/2150

@Aikatsui commented on GitHub (Oct 3, 2020): https://github.com/AdguardTeam/AdGuardHome/issues/2150

deekerman commented

2026-03-04 01:20:00 -05:00

Author

Owner

@ameshkov commented on GitHub (Oct 5, 2020):

Btw, we implemented unblocking CIDRs after all so I guess this feature request is not needed anymore. The fix is available in the edge channel.

@ameshkov commented on GitHub (Oct 5, 2020): Btw, we implemented unblocking CIDRs after all so I guess this feature request is not needed anymore. The fix is available in the edge channel.

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/AdGuardHome#1480

No description provided.

Rows
Columns