mirror of
https://github.com/AdguardTeam/AdGuardHome.git
synced 2026-03-04 00:01:12 -05:00
Option for logging AGH's own DNS requests. #1851
Labels
No labels
P1: Critical
P2: High
P3: Medium
P4: Low
UI
bug
cannot reproduce
compatibility
dependencies
docker
documentation
duplicate
enhancement
enhancement
external libs
feature request
good first issue
help wanted
infrastructure
invalid
localization
needs investigation
performance
potential-duplicate
question
recurrent
research
snap
waiting for data
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/AdGuardHome#1851
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @adamgibbo on GitHub (Aug 3, 2020).
Problem Description
AdGuard Home does make DNS requests itself, but does not show on the query log.
Proposed Solution
In the interests of openness, please allow an option for logging of AdGuard Home's DNS requests
Alternatives Considered
Understandably AdGuard Home makes a lot of requests due to safebrowsing. Perhaps make this a disabled by default option or enabled in .yaml file only.
@ameshkov commented on GitHub (Aug 3, 2020):
@szolin is it easy to do or not? Tbh, there's always a simple solution - write this to the regular log file (if we don't do that already).
It makes many requests, but not DNS requests. Once the domain name is resolved, it's cached and not queried anymore.
@adamgibbo commented on GitHub (Aug 3, 2020):
Even though this specific request is for AGH. This is also something that I'd thought about with AdGuard for Android too. I think the log should show ALL DNS requests, even DNS bootstrap.
@szolin commented on GitHub (Aug 4, 2020):
Let's first define explicitly what is "Query Log".
As I understand it's a log of requests AGH receives from the outside (i.e. a client connects via TCP or UDP and sends a DNS request to AGH) and processes according to its configuration.
Of course we can add anything there, including our own direct requests to upstream servers and requests to family.adguard server. But if we do so, my understanding of "Query Log" becomes incorrect, then let someone define what is "Query Log".
@ameshkov commented on GitHub (Aug 4, 2020):
Well, I kinda agree. I think internal queries should go to the regular log, not the query log
@stale[bot] commented on GitHub (Oct 3, 2020):
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.