Add support for "!#include" #2018

Open
opened 2026-03-04 01:42:43 -05:00 by deekerman · 1 comment
Owner

Originally created by @DandelionSprout on GitHub (Oct 10, 2020).

Originally assigned to: @ainar-g on GitHub.

Prerequisites

  • I am running the latest version (0.104.0-beta1)
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

Issue Details

  • Version of AdGuard Home server:
    • 0.104.0-beta1
  • How did you setup DNS configuration:
    • N/A
  • If it's a router or IoT, please write device model:
    • Raspberry Pi 4
  • Operating system and version:
    • Raspberry Pi OS Bullseye 32-bit

Expected Behavior

Currently, AdGuard Home does not recognise !#include tags that are used to load additional list files, as seen in uBlock Origin and to a fairly small degree AdGuard for Windows/Mac/browsers. It'd have been pretty cool if it became supported, including in lists that are not natively included in AdGuard Home.

Actual Behavior

AdGuard Home does not recognise !#include tags.

Screenshots

Screenshot:

image

Additional Information

If you need a test file to test such a new function with, my personal-use-only list would be a very solid test subject; because it shows only ~1,200 entries in AdGuard's filters menu without !#include, but would increase to 11,000~14,000 with full support for !#include, and also has up to three tiers of !#include links themselves using !#include links.

If you instead need to test with a publicly intended list without any odd-looking content whatsoever, Dandelion Sprout's Annoyances List is also available.

Originally created by @DandelionSprout on GitHub (Oct 10, 2020). Originally assigned to: @ainar-g on GitHub. <!-- As an open-source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can. --> ### Prerequisites - [x] I am running the latest version (0.104.0-beta1) - [x] I checked the documentation and found no answer - [x] I checked to make sure that this issue has not already been filed ### Issue Details <!--- Please include all relevant details about the environment you experienced the bug in --> * **Version of AdGuard Home server:** * 0.104.0-beta1 * **How did you setup DNS configuration:** * N/A * **If it's a router or IoT, please write device model:** * Raspberry Pi 4 * **Operating system and version:** * Raspberry Pi OS Bullseye 32-bit ### Expected Behavior Currently, AdGuard Home does not recognise `!#include` tags that are used to load additional list files, as seen in uBlock Origin and to a fairly small degree AdGuard for Windows/Mac/browsers. It'd have been pretty cool if it became supported, including in lists that are not natively included in AdGuard Home. ### Actual Behavior AdGuard Home does not recognise `!#include` tags. ### Screenshots <!-- If applicable, add screenshots to help explain your problem. --> <details><summary>Screenshot:</summary> ![image](https://user-images.githubusercontent.com/22780683/95664933-1dc80580-0b4c-11eb-87f3-e8883ca10ef1.png) </details> ### Additional Information If you need a test file to test such a new function with, [my personal-use-*only* list](https://raw.githubusercontent.com/DandelionSprout/adfilt/master/a.txt) would be a very solid test subject; because it shows only \~1,200 entries in AdGuard's filters menu without `!#include`, but would increase to 11,000\~14,000 with full support for `!#include`, and also has up to three tiers of `!#include` links themselves using `!#include` links. If you instead need to test with a publicly intended list without any odd-looking content whatsoever, [Dandelion Sprout's Annoyances List](https://raw.githubusercontent.com/DandelionSprout/adfilt/master/AnnoyancesList) is also available.
Author
Owner

@ameshkov commented on GitHub (Oct 11, 2020):

This is a nice feature request, but I can't assign it to a version yet. Let it be v0.108 for now so that I don't forget about it.

Also, I suppose this should be a part of https://github.com/AdguardTeam/urlfilter library.

@ameshkov commented on GitHub (Oct 11, 2020): This is a nice feature request, but I can't assign it to a version yet. Let it be v0.108 for now so that I don't forget about it. Also, I suppose this should be a part of https://github.com/AdguardTeam/urlfilter library.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/AdGuardHome#2018
No description provided.