mirror of
https://github.com/AdguardTeam/AdGuardHome.git
synced 2026-03-04 00:01:12 -05:00
Add support for "!#include" #2018
Labels
No labels
P1: Critical
P2: High
P3: Medium
P4: Low
UI
bug
cannot reproduce
compatibility
dependencies
docker
documentation
duplicate
enhancement
enhancement
external libs
feature request
good first issue
help wanted
infrastructure
invalid
localization
needs investigation
performance
potential-duplicate
question
recurrent
research
snap
waiting for data
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/AdGuardHome#2018
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @DandelionSprout on GitHub (Oct 10, 2020).
Originally assigned to: @ainar-g on GitHub.
Prerequisites
Issue Details
Expected Behavior
Currently, AdGuard Home does not recognise
!#includetags that are used to load additional list files, as seen in uBlock Origin and to a fairly small degree AdGuard for Windows/Mac/browsers. It'd have been pretty cool if it became supported, including in lists that are not natively included in AdGuard Home.Actual Behavior
AdGuard Home does not recognise
!#includetags.Screenshots
Screenshot:
Additional Information
If you need a test file to test such a new function with, my personal-use-only list would be a very solid test subject; because it shows only ~1,200 entries in AdGuard's filters menu without
!#include, but would increase to 11,000~14,000 with full support for!#include, and also has up to three tiers of!#includelinks themselves using!#includelinks.If you instead need to test with a publicly intended list without any odd-looking content whatsoever, Dandelion Sprout's Annoyances List is also available.
@ameshkov commented on GitHub (Oct 11, 2020):
This is a nice feature request, but I can't assign it to a version yet. Let it be v0.108 for now so that I don't forget about it.
Also, I suppose this should be a part of https://github.com/AdguardTeam/urlfilter library.