mirror of
https://github.com/AdguardTeam/AdGuardHome.git
synced 2026-03-04 00:01:12 -05:00
The language selected is not applied on the login page #2214
Labels
No labels
P1: Critical
P2: High
P3: Medium
P4: Low
UI
bug
cannot reproduce
compatibility
dependencies
docker
documentation
duplicate
enhancement
enhancement
external libs
feature request
good first issue
help wanted
infrastructure
invalid
localization
needs investigation
performance
potential-duplicate
question
recurrent
research
snap
waiting for data
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/AdGuardHome#2214
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ghost on GitHub (Dec 1, 2020).
Originally assigned to: @ArtemBaskal on GitHub.
Prerequisites
Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.
Problem Description
When i open my adguard home page it reset language in english (on login form) and when i connect myself it revert back to the languages i have choosed
Proposed Solution
use a cookie to store the language even when not connected
Alternatives Considered
use the local storage to do so
@Aikatsui commented on GitHub (Dec 1, 2020):
Reset language (present) to english is unnecessary because adguardhome doesn't has or need account registration then it's enough to keep "administrator" user language as default for home page even after introduced #997 (user accounts)
@ghost commented on GitHub (Dec 1, 2020):
yes but actually the administrator is in french not English, so i don't understand why it reset to English if i'm not logged, why does it not show itself in the languages i have selected (i ask to see if it's a problem on my side or a normal behavior).
@ameshkov commented on GitHub (Dec 1, 2020):
So basically the problem is that the language you chose is not applied on the login page, right?
@ameshkov commented on GitHub (Dec 1, 2020):
@ArtemBaskal take a look plz, it should be relatively easy to fix.
@ghost commented on GitHub (Dec 1, 2020):
exact, i have checked on the yaml language is "fr" but on login page when i first connect is in English, but on the launch of login page it show in English.
If i'm connecting myself the langage is french so only the login page don't follow this settings.
@ghost commented on GitHub (Dec 1, 2020):
@ameshkov its seem to be a bug (corrected on this release) of local storage who was wiped on every boot of edge, sorry for the loss of time