mirror of
https://github.com/AdguardTeam/AdGuardHome.git
synced 2026-03-04 00:01:12 -05:00
ADH ignores external Whitelist rules #2259
Labels
No labels
P1: Critical
P2: High
P3: Medium
P4: Low
UI
bug
cannot reproduce
compatibility
dependencies
docker
documentation
duplicate
enhancement
enhancement
external libs
feature request
good first issue
help wanted
infrastructure
invalid
localization
needs investigation
performance
potential-duplicate
question
recurrent
research
snap
waiting for data
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/AdGuardHome#2259
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ExternalDatabase on GitHub (Dec 13, 2020).
Originally assigned to: @EugeneOne1 on GitHub.
Issue Details
Expected Behavior
Adguard Home should understand and apply external whitelist rules over the blocking ones.
Actual Behavior
I have one external whitelist in section Filters > DNS allowlists
That list is hosted on GitHub (domain https://gist.githubusercontent.com/...) and has Adb format checked with Adguard Home documentation.
It's enabled, refreshing every 12 hours and Adguard Home shows correct number of rules (60) and correct last time updated.
Rules inside that list are 100% correct (checked in docs) and sometimes copy-pasted from Filters > Custom filtering rules (after that removed from custom list).
Adguard Home uses custom blocklist i.e. to block Microsoft telemetry, so the address login.live.com is blocked.
I need it to be not blocked, so I clicked on "Unblock" button on Querylist, then I went to Filters > Custom filtering rules and copied that entry from custom rules to my Github-hosted whitelist with that syntax:
@@||login.live.com^$important
After that I updated Adguard Home allowlists. I see the domains count got +1, update time refreshed and when I clicked on link it shows me the actual list with that rule present.
I flushed DNS on my PC and browser and it passed (OK) until next scheduled lists refresh time.
It stopped working next day (query of domain login.live.com is blocked again).
@ameshkov commented on GitHub (Dec 14, 2020):
If you're using
@@-kind of rules (which "allow" content by themselves), you don't have to use "Allowlists". On the contrary, you can simply use "Blocklists" and your custom list there. This way you can use your list not just to unblock stuff, but to block as well.Regarding the original issue, I am not able to reproduce it on my side.
Do you still have the rule on your list?
Could you please share the list with us so that we could try to reproduce this?
Or maybe create a new one (with which the issue is reproduced) and share it?
@EugeneOne1 commented on GitHub (Dec 18, 2020):
We're closing this issue for now. Please feel free to reopen it if our solution won't solve it.