Remove on-change callbacks #2604

Closed
opened 2026-03-04 02:08:53 -05:00 by deekerman · 1 comment
Owner

Originally created by @ainar-g on GitHub (Mar 26, 2021).

Currently, the code uses a network of callbacks to signal changes to certain parts of the system. Needless to say, some of these have become quite macaroni-ish, including potential issues with locking. We write in Go, so replacing most of this machinery with a simple pub-sub mechanism is a no-brainer.

Originally created by @ainar-g on GitHub (Mar 26, 2021). Currently, the code uses a network of callbacks to signal changes to certain parts of the system. Needless to say, some of these have become quite macaroni-ish, including potential issues with locking. We write in Go, so replacing most of this machinery with a simple pub-sub mechanism is a no-brainer.
deekerman 2026-03-04 02:08:53 -05:00
  • closed this issue
  • added the
    duplicate
    label
Author
Owner

@ainar-g commented on GitHub (Feb 1, 2022):

Merging into #2075.

@ainar-g commented on GitHub (Feb 1, 2022): Merging into #2075.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/AdGuardHome#2604
No description provided.