mirror of
https://github.com/AdguardTeam/AdGuardHome.git
synced 2026-03-04 00:01:12 -05:00
Remove on-change callbacks #2604
Labels
No labels
P1: Critical
P2: High
P3: Medium
P4: Low
UI
bug
cannot reproduce
compatibility
dependencies
docker
documentation
duplicate
enhancement
enhancement
external libs
feature request
good first issue
help wanted
infrastructure
invalid
localization
needs investigation
performance
potential-duplicate
question
recurrent
research
snap
waiting for data
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/AdGuardHome#2604
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ainar-g on GitHub (Mar 26, 2021).
Currently, the code uses a network of callbacks to signal changes to certain parts of the system. Needless to say, some of these have become quite macaroni-ish, including potential issues with locking. We write in Go, so replacing most of this machinery with a simple pub-sub mechanism is a no-brainer.
@ainar-g commented on GitHub (Feb 1, 2022):
Merging into #2075.