Provide option for custom service defenition from the config. #2732

Closed
opened 2026-03-04 02:16:53 -05:00 by deekerman · 1 comment
Owner

Originally created by @kisst on GitHub (May 5, 2021).

Prerequisites

Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

Problem Description

Handling per client rules in custom rules is possible, but not too handy in practice due to the complex rule expressions.
The list of services defined is short, and not extendable.

Proposed Solution

Allow users to extend the internal/dnsfilter/blocked.go serviceRulesArray with custom definitions, even better if this can be consumed like the block list itself, aka based on a feed.

Specific use-case, blocking CDN access to any CSS JS etc static lib which with browser plugin can be injected back into cache so page functionality does not break, hence it can be blocked on DNS level, but for clients where this is not an option, this "service" should be enabled, OR an other specific use-case is connectivity check endpoints, most of the device talk home with performing "am I online" connectivity checks, this can be by default blocked, but some devices will just drop the connection if they don't "think" that they are online, so having this defined as a service, would make it easy to switch on and off.

Alternatives Considered

The current way to do this now, is use labels, and label specific rules, which works ™️ but pretty complex to handle.

Additional Information

Icons, and etc in case custom service definitions can be generic.

Originally created by @kisst on GitHub (May 5, 2021). ### Prerequisites Please answer the following questions for yourself before submitting an issue. **YOU MAY DELETE THE PREREQUISITES SECTION.** - [X] I am running the latest version - [X] I checked the documentation and found no answer - [X] I checked to make sure that this issue has not already been filed ### Problem Description <!-- Is your feature request related to a problem? Please add a clear and concise description of what the problem is. --> Handling per client rules in custom rules is possible, but not too handy in practice due to the complex rule expressions. The list of services defined is short, and not extendable. ### Proposed Solution <!-- Describe the solution you'd like in a clear and concise manner --> Allow users to extend the `internal/dnsfilter/blocked.go` serviceRulesArray with custom definitions, even better if this can be consumed like the block list itself, aka based on a feed. Specific use-case, blocking CDN access to any CSS JS etc static lib which with browser plugin can be injected back into cache so page functionality does not break, hence it can be blocked on DNS level, but for clients where this is not an option, this "service" should be enabled, OR an other specific use-case is connectivity check endpoints, most of the device talk home with performing "am I online" connectivity checks, this can be by default blocked, but some devices will just drop the connection if they don't "think" that they are online, so having this defined as a service, would make it easy to switch on and off. ### Alternatives Considered <!-- A clear and concise description of any alternative solutions or features you've considered. --> The current way to do this now, is use labels, and label specific rules, which works :tm: but pretty complex to handle. ### Additional Information <!-- Add any other context about the problem here. --> Icons, and etc in case custom service definitions can be generic.
deekerman 2026-03-04 02:16:53 -05:00
  • closed this issue
  • added the
    duplicate
    label
Author
Owner

@ameshkov commented on GitHub (May 7, 2021):

Duplicates #1692

@ameshkov commented on GitHub (May 7, 2021): Duplicates #1692
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/AdGuardHome#2732
No description provided.