mirror of
https://github.com/AdguardTeam/AdGuardHome.git
synced 2026-03-04 00:01:12 -05:00
Provide option for custom service defenition from the config. #2732
Labels
No labels
P1: Critical
P2: High
P3: Medium
P4: Low
UI
bug
cannot reproduce
compatibility
dependencies
docker
documentation
duplicate
enhancement
enhancement
external libs
feature request
good first issue
help wanted
infrastructure
invalid
localization
needs investigation
performance
potential-duplicate
question
recurrent
research
snap
waiting for data
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/AdGuardHome#2732
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @kisst on GitHub (May 5, 2021).
Prerequisites
Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.
Problem Description
Handling per client rules in custom rules is possible, but not too handy in practice due to the complex rule expressions.
The list of services defined is short, and not extendable.
Proposed Solution
Allow users to extend the
internal/dnsfilter/blocked.goserviceRulesArray with custom definitions, even better if this can be consumed like the block list itself, aka based on a feed.Specific use-case, blocking CDN access to any CSS JS etc static lib which with browser plugin can be injected back into cache so page functionality does not break, hence it can be blocked on DNS level, but for clients where this is not an option, this "service" should be enabled, OR an other specific use-case is connectivity check endpoints, most of the device talk home with performing "am I online" connectivity checks, this can be by default blocked, but some devices will just drop the connection if they don't "think" that they are online, so having this defined as a service, would make it easy to switch on and off.
Alternatives Considered
The current way to do this now, is use labels, and label specific rules, which works ™️ but pretty complex to handle.
Additional Information
Icons, and etc in case custom service definitions can be generic.
@ameshkov commented on GitHub (May 7, 2021):
Duplicates #1692