mirror of
https://github.com/AdguardTeam/AdGuardHome.git
synced 2026-03-04 00:01:12 -05:00
Removing leases.db unsets client-requests data #2836
Labels
No labels
P1: Critical
P2: High
P3: Medium
P4: Low
UI
bug
cannot reproduce
compatibility
dependencies
docker
documentation
duplicate
enhancement
enhancement
external libs
feature request
good first issue
help wanted
infrastructure
invalid
localization
needs investigation
performance
potential-duplicate
question
recurrent
research
snap
waiting for data
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/AdGuardHome#2836
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @agneevX on GitHub (Jun 7, 2021).
Prerequisites
Environment
Issue Details
I had to remove
leases.dbbecause a certain DHCP client's hostname was showing up blank.After I started up AGH, the client's hostname was correctly visible
However, after I renewed leases on a few devices, I noticed that Top Clients was showing incorrect data for hostnames.
Expected Behavior
Historical queries would get mapped correctly to the client.
Is there a way I can rectify this at this time?3
@ainar-g commented on GitHub (Jun 7, 2021):
Hi. Unfortunately I don't think that this is currently possible, as these statistics are joined to the data from the leases database. Such situations should become less frequent once we find a better storage format in #2290.
@agneevX commented on GitHub (Jun 7, 2021):
Ah ok! As of now, how are queries mapped to clients?
If it's dynamic, I'm not sure why it can't be mapped, unless AGH tends to give the same DHCP IP to clients?
@ainar-g commented on GitHub (Jun 7, 2021):
They are mapped by ClientID and, if there is none, by IP address. So, if your DHCP clients receive a different IP address, the stats won't be accurate. Creating clients by MAC would fix it, but our current stats don't know anything about MAC, unfortunately. Most of these issues should get solved once we have a better database.
I'll close this issue, if you don't mind, as there is little we can do here at the moment. Apologies for the inconvenience!