mirror of
https://github.com/AdguardTeam/AdGuardHome.git
synced 2026-03-04 00:01:12 -05:00
Disk space issues and log rotation. (OpenWRT) #3161
Labels
No labels
P1: Critical
P2: High
P3: Medium
P4: Low
UI
bug
cannot reproduce
compatibility
dependencies
docker
documentation
duplicate
enhancement
enhancement
external libs
feature request
good first issue
help wanted
infrastructure
invalid
localization
needs investigation
performance
potential-duplicate
question
recurrent
research
snap
waiting for data
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/AdGuardHome#3161
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @mercyground on GitHub (Nov 3, 2021).
Originally assigned to: @ainar-g on GitHub.
Prerequisites
Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.
Issue Details
Version of AdGuard Home server:
How did you install AdGuard Home:
If it's a router or IoT, please write device model:
CPU architecture:
Operating system and version:
Expected Behavior
Currently AGH copies its binary and config to the /opt/AdGuardHome/agh-backup folder on upgrade. However it does not appear to check for available diskspace before it does so and thus on limited space filesystems AGH fails the upgrade and does not report reason why on the control panel (however it does report on the router logs). A error message back to the web console would be appreciated.
Also AGH recently changed how it managed logs/query logging but there is no way to have it purge the old logs at the rotation leading to double the disk space needed?
github.com/AdguardTeam/AdGuardHome@1e72960140At present i manage these issues by manually deleting the rotated logs and purging the backed up copy of AGH once it has updated to stop AGH running out of disk space. A method for managing this or even a warning to the console that disk space is low would be a good addition.
@ainar-g commented on GitHub (Nov 3, 2021):
Thank you for your report! The error message should definitely be added / improved. As for the log rotation and doubling, #3404 should allow you to simply set a lower custom value for log rotation.
@mercyground commented on GitHub (Nov 3, 2021):
As part of the upgrade a simple disk space check should be done maybe?
So you click the upgrade and it checks to see if there is space and warns you to fix the issue rather than a failed upgrade would be a better experience.
The logging space issues can be managed by just keeping shorter logs on OpenWRT or limited space devices.
@ainar-g commented on GitHub (Dec 30, 2021):
Okay, so after some researching, I'm not sure that we'll be able to do this properly in the v0.107 cycle. In order to know if there is enough disk space, we'll need to get the data about the compressed and uncompressed size of the release, and that information is currently unavailable to us.
Besides, our update procedure just generally needs a refactoring, and that's supposed to happen in the v0.108 cycle, see #2630.