mirror of
https://github.com/AdguardTeam/AdGuardHome.git
synced 2026-03-04 00:01:12 -05:00
Consider custom port in Dockerfile healthcheck #4349
Labels
No labels
P1: Critical
P2: High
P3: Medium
P4: Low
UI
bug
cannot reproduce
compatibility
dependencies
docker
documentation
duplicate
enhancement
enhancement
external libs
feature request
good first issue
help wanted
infrastructure
invalid
localization
needs investigation
performance
potential-duplicate
question
recurrent
research
snap
waiting for data
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/AdGuardHome#4349
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @EugeneOne1 on GitHub (Mar 28, 2023).
Originally assigned to: @EugeneOne1 on GitHub.
Prerequisites
I have checked the Wiki and Discussions and found no answer
I have searched other issues and found no duplicates
I want to request a feature or enhancement and not ask a question
Description
In #3290 we've implemented the Docker-provided healthcheck. Currently it supports parsing the configuration file, fetching the root endpoint of web UI, and requesting DNS. It also detects if AdGuard Home isn't yet configured and tries to reach the installation endpoint in this case.
Though, the official Dockerfile intends using port
3000for installation web UI endpoint, there is a use case where user can specify some custom port via command-line options. Note also, that custom port can be specified after installation as well. Both these cases should be covered.@EugeneOne1 commented on GitHub (Aug 21, 2023):
As of
v0.108.0-a.603+f7dd8325, AdGuard Home no longer supports the Dockerfile healthcheck mechanism, so this issue doesn't seem to be relevant.