starred/AdGuardHome

Fork 0

mirror of https://github.com/AdguardTeam/AdGuardHome.git synced 2026-03-04 00:01:12 -05:00

Make field "Bootstrap DNS servers" accept upstream syntax #4669

New issue

Open

opened 2026-03-04 05:25:43 -05:00 by deekerman · 3 comments

deekerman commented

2026-03-04 05:25:43 -05:00

Owner

Originally created by @Ziris85 on GitHub (Aug 21, 2023).

Originally assigned to: @ainar-g on GitHub.

Prerequisites

I have checked the Wiki and Discussions and found no answer
I have searched other issues and found no duplicates
I want to report a bug and not ask a question or ask for help
I have set up AdGuard Home correctly and configured clients to use it. (Use the Discussions for help with installing and configuring clients.)

Platform (OS and CPU architecture)

Linux, AMD64 (aka x86_64)

Installation

Snapcraft

Setup

On one machine

AdGuard Home version

0.107.36

Action

I attempted to add comments to the "Bootstrap DNS servers" text box. Attempting to apply or test the upstreams results in an error:

Error: control/dns_config | checking bootstrap # 9.9.9.10: invalid address: bootstrap # 9.9.9.10:53: ParseAddr("# 9.9.9.10"): unexpected character (at "# 9.9.9.10") | 400

Contents that I'm testing with are:

# 9.9.9.10
149.112.112.10
2620:fe::10
2620:fe::fe:10

Expected result

The "Examples" section immediately above the textbox indicate that lines leading with # are proper syntax for comments, so I would expect the syntax to validate and for AdGuard to ignore the lines indicated as comments

Actual result

AdGuard fails to validate the config and refuses to apply the settings

Additional information and/or screenshots

No response

Originally created by @Ziris85 on GitHub (Aug 21, 2023). Originally assigned to: @ainar-g on GitHub. ### Prerequisites - [X] I have checked the [Wiki](https://github.com/AdguardTeam/AdGuardHome/wiki) and [Discussions](https://github.com/AdguardTeam/AdGuardHome/discussions/categories/q-a) and found no answer - [X] I have searched other issues and found no duplicates - [X] I want to report a bug and not [ask a question or ask for help](https://github.com/AdguardTeam/AdGuardHome/discussions/categories/q-a) - [X] I have set up AdGuard Home correctly and [configured clients to use it](https://github.com/AdguardTeam/AdGuardHome/wiki/Clients). (Use the [Discussions](https://github.com/AdguardTeam/AdGuardHome/discussions/categories/q-a) for help with installing and configuring clients.) ### Platform (OS and CPU architecture) Linux, AMD64 (aka x86_64) ### Installation Snapcraft ### Setup On one machine ### AdGuard Home version 0.107.36 ### Action I attempted to add comments to the "Bootstrap DNS servers" text box. Attempting to apply or test the upstreams results in an error: ``` Error: control/dns_config | checking bootstrap # 9.9.9.10: invalid address: bootstrap # 9.9.9.10:53: ParseAddr("# 9.9.9.10"): unexpected character (at "# 9.9.9.10") | 400 ``` Contents that I'm testing with are: ``` # 9.9.9.10 149.112.112.10 2620:fe::10 2620:fe::fe:10 ``` ### Expected result The "Examples" section immediately above the textbox indicate that lines leading with `#` are proper syntax for comments, so I would expect the syntax to validate and for AdGuard to ignore the lines indicated as comments ### Actual result AdGuard fails to validate the config and refuses to apply the settings ### Additional information and/or screenshots _No response_

deekerman added the

enhancement

P3: Medium

labels

2026-03-04 05:25:43 -05:00

deekerman commented

2026-03-04 05:25:52 -05:00

Author

Owner

@Ziris85 commented on GitHub (Aug 21, 2023):

Realized my initial config wasn't actually valid, so tested again with valid configs and verified the issue is still present. Updated initial comment with what should otherwise be valid configs

@Ziris85 commented on GitHub (Aug 21, 2023): Realized my initial config wasn't actually valid, so tested again with valid configs and verified the issue is still present. Updated initial comment with what should otherwise be valid configs

deekerman commented

2026-03-04 05:26:00 -05:00

Author

Owner

@ainar-g commented on GitHub (Aug 22, 2023):

The bootstrap field only really accepts IP addresses, if I recall correctly. It's not a proper upstream config currently, so no comments and no domain-specific rules. At the very least, the UI needs to be updated to make that clear.

@ainar-g commented on GitHub (Aug 22, 2023): The bootstrap field only really accepts IP addresses, if I recall correctly. It's not a proper upstream config currently, so no comments and no domain-specific rules. At the very least, the UI needs to be updated to make that clear.

deekerman commented

2026-03-04 05:26:00 -05:00

Author

Owner

@ainar-g commented on GitHub (Sep 7, 2023):

The UI changes will arrive in v0.107.37. I will retitle this issue to be about the support for the full upstream syntax, including comments.

@ainar-g commented on GitHub (Sep 7, 2023): The UI changes will arrive in v0.107.37. I will retitle this issue to be about the support for the full upstream syntax, including comments.

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/AdGuardHome#4669

No description provided.

Rows
Columns