Merge per client's different addresses in top clients. #4828

Open
opened 2026-03-04 05:35:35 -05:00 by deekerman · 3 comments
Owner

Originally created by @fernvenue on GitHub (Oct 26, 2023).

Prerequisites

  • I have checked the Wiki and Discussions and found no answer

  • I have searched other issues and found no duplicates

  • I want to request a feature or enhancement and not ask a question

The problem

I just found out that the top clients part in dashboard will show per client's all different addresses, is that a feature?

Proposed solution

Maybe merge per client's different addresses will be great :)

Alternatives considered and additional information

Make it optional to choose how to show in dashboard.

Originally created by @fernvenue on GitHub (Oct 26, 2023). ### Prerequisites - [X] I have checked the [Wiki](https://github.com/AdguardTeam/AdGuardHome/wiki) and [Discussions](https://github.com/AdguardTeam/AdGuardHome/discussions) and found no answer - [X] I have searched other issues and found no duplicates - [X] I want to request a feature or enhancement and not ask a question ### The problem I just found out that the *top clients* part in dashboard will show per client's all different addresses, is that a feature? ### Proposed solution Maybe merge per client's different addresses will be great :) ### Alternatives considered and additional information Make it optional to choose how to show in dashboard.
Author
Owner

@ainar-g commented on GitHub (Oct 26, 2023):

I'm not quite sure I understand what you are requesting, sorry. Can you demonstrate on an example?

@ainar-g commented on GitHub (Oct 26, 2023): I'm not quite sure I understand what you are requesting, sorry. Can you demonstrate on an example?
Author
Owner

@fernvenue commented on GitHub (Oct 26, 2023):

Hi @ainar-g, thanks for your reply. Here's an example:

image

I added this device's both IPv4 and IPv6 addresses in Client settings - Identifier, but I'm little bit confused by Top clients here, I think that the number of addresses should not change the fact that it is a single device not multiple devices right?

By the way, some devices (such as iPhone) sometimes will send requests from multiple addresses in fe80::/10, and they all showed one by one, that's why I think merge per client's different addresses will be great, or make it optional to choose how to show in dashboard.

@fernvenue commented on GitHub (Oct 26, 2023): Hi @ainar-g, thanks for your reply. Here's an example: ![image](https://github.com/AdguardTeam/AdGuardHome/assets/84565547/99ecdfce-346b-4a07-b632-40bb9728312a) I added this device's both IPv4 and IPv6 addresses in *Client settings - Identifier*, but I'm little bit confused by *Top clients* here, I think that the number of addresses should not change the fact that it is a single device not multiple devices right? By the way, some devices (such as iPhone) sometimes will send requests from multiple addresses in `fe80::/10`, and they all showed one by one, that's why I think merge per client's different addresses will be great, or make it optional to choose how to show in dashboard.
Author
Owner

@ainar-g commented on GitHub (Oct 26, 2023):

Ah, I see, thanks. That table on the dashboard is actually an IP-based one, with the persistent client information added merely for the context. Considering that “client” is a bit of a nebulous term and also that one UI will never satisfy everyone, there are a few ways to display that information, and we're not sure which one is better.

@ainar-g commented on GitHub (Oct 26, 2023): Ah, I see, thanks. That table on the dashboard is actually an IP-based one, with the persistent client information added merely for the context. Considering that “client” is a bit of a nebulous term and also that one UI will never satisfy everyone, there are a few ways to display that information, and we're not sure which one is better.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/AdGuardHome#4828
No description provided.