mirror of
https://github.com/AdguardTeam/AdGuardHome.git
synced 2026-03-04 00:01:12 -05:00
Merge per client's different addresses in top clients. #4828
Labels
No labels
P1: Critical
P2: High
P3: Medium
P4: Low
UI
bug
cannot reproduce
compatibility
dependencies
docker
documentation
duplicate
enhancement
enhancement
external libs
feature request
good first issue
help wanted
infrastructure
invalid
localization
needs investigation
performance
potential-duplicate
question
recurrent
research
snap
waiting for data
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/AdGuardHome#4828
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @fernvenue on GitHub (Oct 26, 2023).
Prerequisites
I have checked the Wiki and Discussions and found no answer
I have searched other issues and found no duplicates
I want to request a feature or enhancement and not ask a question
The problem
I just found out that the top clients part in dashboard will show per client's all different addresses, is that a feature?
Proposed solution
Maybe merge per client's different addresses will be great :)
Alternatives considered and additional information
Make it optional to choose how to show in dashboard.
@ainar-g commented on GitHub (Oct 26, 2023):
I'm not quite sure I understand what you are requesting, sorry. Can you demonstrate on an example?
@fernvenue commented on GitHub (Oct 26, 2023):
Hi @ainar-g, thanks for your reply. Here's an example:
I added this device's both IPv4 and IPv6 addresses in Client settings - Identifier, but I'm little bit confused by Top clients here, I think that the number of addresses should not change the fact that it is a single device not multiple devices right?
By the way, some devices (such as iPhone) sometimes will send requests from multiple addresses in
fe80::/10, and they all showed one by one, that's why I think merge per client's different addresses will be great, or make it optional to choose how to show in dashboard.@ainar-g commented on GitHub (Oct 26, 2023):
Ah, I see, thanks. That table on the dashboard is actually an IP-based one, with the persistent client information added merely for the context. Considering that “client” is a bit of a nebulous term and also that one UI will never satisfy everyone, there are a few ways to display that information, and we're not sure which one is better.