starred/AdGuardHome

Fork 0

mirror of https://github.com/AdguardTeam/AdGuardHome.git synced 2026-03-04 00:01:12 -05:00

Client modifier breaking custom filter rules #4843

New issue

Closed

opened 2026-03-04 05:36:11 -05:00 by deekerman · 2 comments

deekerman commented

2026-03-04 05:36:11 -05:00

Owner

Originally created by @lolgast1987 on GitHub (Oct 31, 2023).

Prerequisites

I have checked the Wiki and Discussions and found no answer
I have searched other issues and found no duplicates
I want to report a bug and not ask a question or ask for help
I have set up AdGuard Home correctly and configured clients to use it. (Use the Discussions for help with installing and configuring clients.)

Platform (OS and CPU architecture)

Linux, AMD64 (aka x86_64)

Installation

GitHub releases or script from README

Setup

On one machine

AdGuard Home version

0.107.40

Action

I am trying to get dnsrewrites to work with the 'client' modifier, but as soon as I add this modifier the corresponding rule isn't working anymore. Everything else works as expected (i.e. important, dnstype).

I've tried and tried numerous times again, even made a complete new LXC for AdGuard to rule out any problems with old configurations. Simply copying the example from the wiki results in the same issue for me.

When removing the client modifier everything works as expected

Expected result

I expect the 'Check the filtering' feature to output a working rule, but it simply states that the domain I am trying to rewrite isn't in my filter list

Actual result

example.org
Not found in your filter lists

Additional information and/or screenshots

Fresh install on both a Debian 12 and an Alpine 3.18 LXC, installed via the Github installscript. DHCP is running on my router. I do have some client configured in AGH but trying to filter those clients via their name results in the same issue unfortunately.

Originally created by @lolgast1987 on GitHub (Oct 31, 2023). ### Prerequisites - [X] I have checked the [Wiki](https://github.com/AdguardTeam/AdGuardHome/wiki) and [Discussions](https://github.com/AdguardTeam/AdGuardHome/discussions/categories/q-a) and found no answer - [X] I have searched other issues and found no duplicates - [X] I want to report a bug and not [ask a question or ask for help](https://github.com/AdguardTeam/AdGuardHome/discussions/categories/q-a) - [X] I have set up AdGuard Home correctly and [configured clients to use it](https://github.com/AdguardTeam/AdGuardHome/wiki/Clients). (Use the [Discussions](https://github.com/AdguardTeam/AdGuardHome/discussions/categories/q-a) for help with installing and configuring clients.) ### Platform (OS and CPU architecture) Linux, AMD64 (aka x86_64) ### Installation GitHub releases or script from README ### Setup On one machine ### AdGuard Home version 0.107.40 ### Action I am trying to get dnsrewrites to work with the 'client' modifier, but as soon as I add this modifier the corresponding rule isn't working anymore. Everything else works as expected (i.e. important, dnstype). I've tried and tried numerous times again, even made a complete new LXC for AdGuard to rule out any problems with old configurations. Simply copying the example from the [wiki](https://github.com/AdguardTeam/AdGuardHome/wiki/Hosts-Blocklists#client) results in the same issue for me. ![SCR-20231030-mfwc](https://github.com/AdguardTeam/AdGuardHome/assets/30660010/554732c5-4c0c-4cc8-b3ab-8460884d0029) When removing the client modifier everything works as expected ![SCR-20231030-mgqt](https://github.com/AdguardTeam/AdGuardHome/assets/30660010/7078236e-61c9-42e4-bb97-f9081f6709db) ### Expected result I expect the 'Check the filtering' feature to output a working rule, but it simply states that the domain I am trying to rewrite isn't in my filter list ### Actual result example.org Not found in your filter lists ### Additional information and/or screenshots Fresh install on both a Debian 12 and an Alpine 3.18 LXC, installed via the Github installscript. DHCP is running on my router. I do have some client configured in AGH but trying to filter those clients via their name results in the same issue unfortunately.

deekerman

2026-03-04 05:36:11 -05:00

closed this issue
added the
invalid
label

deekerman commented

2026-03-04 05:36:18 -05:00

Author

Owner

@ainar-g commented on GitHub (Oct 31, 2023):

I cannot reproduce this. Do you really not see the queries being rewritten when you use e.g. dig or do you just mean that the check does not show anything? Because if the latter, it's #4036.

@ainar-g commented on GitHub (Oct 31, 2023): I cannot reproduce this. Do you really not see the queries being rewritten when you use e.g. `dig` or do you just mean that the check does not show anything? Because if the latter, it's #4036.

deekerman commented

2026-03-04 05:36:19 -05:00

Author

Owner

@lolgast1987 commented on GitHub (Nov 1, 2023):

I am so so so very sorry. I completely f-ed this one up. I forgot to add my proxyservers IP to the trusted_proxies. Added it this morning and the behavior is as expected.
The rule still shows up as non-existing but that'll probably be the same issue as you mentioned.

@lolgast1987 commented on GitHub (Nov 1, 2023): I am so so so very sorry. I completely f-ed this one up. I forgot to add my proxyservers IP to the trusted_proxies. Added it this morning and the behavior is as expected. The rule still shows up as non-existing but that'll probably be the same issue as you mentioned.

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/AdGuardHome#4843

No description provided.

Rows
Columns