mirror of
https://github.com/AdguardTeam/AdGuardHome.git
synced 2026-03-04 00:01:12 -05:00
Enhancement: Served from Optimistic cache information. #5069
Labels
No labels
P1: Critical
P2: High
P3: Medium
P4: Low
UI
bug
cannot reproduce
compatibility
dependencies
docker
documentation
duplicate
enhancement
enhancement
external libs
feature request
good first issue
help wanted
infrastructure
invalid
localization
needs investigation
performance
potential-duplicate
question
recurrent
research
snap
waiting for data
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/AdGuardHome#5069
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @cenk on GitHub (Feb 16, 2024).
Prerequisites
I have checked the Wiki and Discussions and found no answer
I have searched other issues and found no duplicates
I want to request a feature or enhancement and not ask a question
The problem
Is it possible to see "served from Optimistic Cache" information in the Response details page when the responses are served by the Optimistic Cache?
Proposed solution
Is it possible to see "served from Optimistic Cache" information in the Response details page when the responses are served by the Optimistic Cache?
Alternatives considered and additional information
No response
@ainar-g commented on GitHub (Feb 16, 2024):
As far as I know, that information isn't available in the libraries currently.
Can you elaborate on why you want to see this information? Unless there are custom cache configurations involved, all “served from cache” are served from the optimistic one.
@cenk commented on GitHub (Feb 16, 2024):
It would be very useful to be able to see this information without turning on verbose/debug mode. Just like "stale cache" information on the query page in "pi-hole".
@ainar-g commented on GitHub (Feb 16, 2024):
So basically, the data you'd like to see is the number of cache misses due to TTL expiration?
@cenk commented on GitHub (Feb 16, 2024):
No. Just "Served from Optimistic cache" information istead of "served from cache" for each response.
Correction: in pi-hole v6 (beta) version.
@ainar-g commented on GitHub (Feb 16, 2024):
I'm sorry, but in that case what you're asking makes little sense. There are no two separate common caches, there is only one that either has optimistic mode enabled or not.
@cenk commented on GitHub (Feb 16, 2024):
Yes I know. There is only one cache. The name of the label may be different.
May be "Served from cache (Optimistic response)"
May be "Served from cache (Expired)"
@yuxuan0107 commented on GitHub (Feb 25, 2024):
It would be better if you could provide a statistical display of the cache hit ratio
@yuxuan0107 commented on GitHub (Feb 25, 2024):
Of course, if optimistic caching is enabled, the statistics of the cache hit ratio may be inaccurate, so two statistics may be required, one is used to statistically display the hit ratio of the cache, and the other is used to statistically display the accuracy of the cached data in the optimistic cache
@yuxuan0107 commented on GitHub (Feb 25, 2024):
It is also good if you can increase the current cache usage capacity or the current number of caches
@ainar-g commented on GitHub (Feb 27, 2024):
@yuxuan0107, cache statistics are a part of #1453. Please keep discussions on-topic.
@cenk, I'm still not getting the feature request, sorry. What is the problem you're trying to solve? You've mentioned some kind of information that you want to track, but what information? How would it be actionable?
@cenk commented on GitHub (Feb 27, 2024):
@ainar-g, Can optimistic cache information be specified where I marked on this page? like "served from cache (optimistic response)"
@AlexanderSalge commented on GitHub (Oct 23, 2024):
any update on this?