mirror of
https://github.com/AdguardTeam/AdGuardHome.git
synced 2026-03-04 00:01:12 -05:00
Support client group #5213
Labels
No labels
P1: Critical
P2: High
P3: Medium
P4: Low
UI
bug
cannot reproduce
compatibility
dependencies
docker
documentation
duplicate
enhancement
enhancement
external libs
feature request
good first issue
help wanted
infrastructure
invalid
localization
needs investigation
performance
potential-duplicate
question
recurrent
research
snap
waiting for data
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/AdGuardHome#5213
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Ovear on GitHub (May 22, 2024).
Prerequisites
I have checked the Wiki and Discussions and found no answer
I have searched other issues and found no duplicates
I want to request a feature or enhancement and not ask a question
The problem
Although we can currently use subnets/multiples IPs to identify clients.
However, it overrides client name, making it more difficult to filter query logs by client, especially for dual stack network.
Proposed solution
Consider supporting client group may be good.
Alternatives considered and additional information
Add an extra field to show/filter original client identity.
@ainar-g commented on GitHub (May 22, 2024):
Duplicate of #2527 and #5143
@Ovear commented on GitHub (May 22, 2024):
I am not sure if this is a duplicate of those issues, as they focus on "filter rules".
However, the main theme of this issue is filtering query logs, since the ctag won't work with some scenario, such as overriding upstream DNS. And we also cannot search ctag :>
Specifically, if I want to override upstream for some clients, I have to add each client individually to make hostname searches works. Otherwise, I will lose those hostnames when I am searching through query logs.
Any suggestions?
@ainar-g commented on GitHub (May 22, 2024):
The first issue I've mentioned seems to cover settings in general, including custom upstream settings. Searchability in the query logs would probably be implemented after that one as well.