mirror of
https://github.com/AdguardTeam/AdGuardHome.git
synced 2026-03-04 00:01:12 -05:00
Enable sticky header CSS position on top navbar #5258
Labels
No labels
P1: Critical
P2: High
P3: Medium
P4: Low
UI
bug
cannot reproduce
compatibility
dependencies
docker
documentation
duplicate
enhancement
enhancement
external libs
feature request
good first issue
help wanted
infrastructure
invalid
localization
needs investigation
performance
potential-duplicate
question
recurrent
research
snap
waiting for data
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/AdGuardHome#5258
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @timheuer on GitHub (Jun 17, 2024).
Prerequisites
I have checked the Wiki and Discussions and found no answer
I have searched other issues and found no duplicates
I want to request a feature or enhancement and not ask a question
The problem
As I've been navigating around in the portal and scrolling I wanted the header to always be there for quick navigation. I have to scroll back up to the top to change filter views, etc. It's small but a delightful UX to have the headers stick.
Proposed solution
Enable CSS sticky positioning on the header
In https://github.com/AdguardTeam/AdGuardHome/blob/master/client/src/components/Header/Header.css#L35-L39, updating Line 35 to:
Would result in this experience:
https://github.com/user-attachments/assets/7e1d9c83-4672-49eb-b412-d7eee66f99d7
Alternatives considered and additional information
No response
@andylau004 commented on GitHub (Jun 18, 2024):
got it!
i use this code snippet
it works
thks,
@timheuer commented on GitHub (Jun 18, 2024):
I have a PR ready, but per the contribution guidelines, waiting for maintainer discussion.
@ainar-g commented on GitHub (Jun 18, 2024):
I'm not really sure we'd merge it, at least right now. Even when we make popular UI changes with a lot of 👍 reactions people still come to the issue tracker to complain and ask to revert it back. With a change with unknown level of support, this is even more likely.
Then again, if there are enough positive reactions under this issue, and people really want it, we will merge it. (Please no 👍-only comments, only reactions.)
@timheuer commented on GitHub (Jun 18, 2024):
Thanks for expectations @ainar-g! Should I prepare the PR or wait until y'all say you'd take it?
@ainar-g commented on GitHub (Jun 18, 2024):
I feel like it's better to wait. Things can change in the meantime on the front-end side.