User-friendly client name -- Using Reverse DNS lookup #639

Closed
opened 2026-03-04 00:41:15 -05:00 by deekerman · 7 comments
Owner

Originally created by @nightah on GitHub (Apr 5, 2019).

Originally assigned to: @szolin on GitHub.

Similar to #637 it would be nice if AdGuardHome had the ability to perform a reverse DNS lookup to determine the hostname associated to a specific IP address.

This has the advantage of not requiring manual modification of the /etc/hosts file which often will lead to pain and clutter.

In the case of a host entry existing for said IP address, this should overwrite and take precedence over the reverse DNS specified hostname.

Originally created by @nightah on GitHub (Apr 5, 2019). Originally assigned to: @szolin on GitHub. Similar to #637 it would be nice if AdGuardHome had the ability to perform a reverse DNS lookup to determine the hostname associated to a specific IP address. This has the advantage of not requiring manual modification of the `/etc/hosts` file which often will lead to pain and clutter. In the case of a host entry existing for said IP address, this should overwrite and take precedence over the reverse DNS specified hostname.
deekerman 2026-03-04 00:41:15 -05:00
Author
Owner

@ameshkov commented on GitHub (Apr 6, 2019):

@nightah this makes sense indeed, thank you!

@ameshkov commented on GitHub (Apr 6, 2019): @nightah this makes sense indeed, thank you!
Author
Owner

@ameshkov commented on GitHub (Jun 4, 2019):

We missed one thing here: after AGH started up and loaded the "Top clients" list, we should schedule top clients IP addresses for the reverse lookup.

@ameshkov commented on GitHub (Jun 4, 2019): We missed one thing here: after AGH started up and loaded the "Top clients" list, we should schedule top clients IP addresses for the reverse lookup.
Author
Owner

@ameshkov commented on GitHub (Jun 4, 2019):

I see a lot of unnecessary errors in the log:

2019/06/04 16:27:01 [error] len(resp.Answer) != 1
2019/06/04 16:27:01 [error] len(resp.Answer) != 1
2019/06/04 16:27:01 [error] len(resp.Answer) != 1
2019/06/04 16:27:01 [error] not a dns.PTR response
2019/06/04 16:27:01 [error] len(resp.Answer) != 1
2019/06/04 16:27:02 [error] len(resp.Answer) != 1
2019/06/04 16:27:02 [error] len(resp.Answer) != 1
2019/06/04 16:27:02 [error] len(resp.Answer) != 1
2019/06/04 16:27:03 [error] len(resp.Answer) != 1
  1. First of all, these are not actually errors. Not every IP can be looked up, this is a normal behavior
  2. Second, the error message does not explain which of the lookups failed exactly.
@ameshkov commented on GitHub (Jun 4, 2019): I see a lot of unnecessary errors in the log: ``` 2019/06/04 16:27:01 [error] len(resp.Answer) != 1 2019/06/04 16:27:01 [error] len(resp.Answer) != 1 2019/06/04 16:27:01 [error] len(resp.Answer) != 1 2019/06/04 16:27:01 [error] not a dns.PTR response 2019/06/04 16:27:01 [error] len(resp.Answer) != 1 2019/06/04 16:27:02 [error] len(resp.Answer) != 1 2019/06/04 16:27:02 [error] len(resp.Answer) != 1 2019/06/04 16:27:02 [error] len(resp.Answer) != 1 2019/06/04 16:27:03 [error] len(resp.Answer) != 1 ``` 1. First of all, these are not actually errors. Not every IP can be looked up, this is a normal behavior 2. Second, the error message does not explain which of the lookups failed exactly.
Author
Owner

@ameshkov commented on GitHub (Jun 4, 2019):

No rDNS lookups are made for clients that use DOH

@ameshkov commented on GitHub (Jun 4, 2019): No rDNS lookups are made for clients that use DOH
Author
Owner

@db-EV commented on GitHub (Jun 19, 2019):

rDNS lookups would be even better if it was possible to define a specific upstream server for a specific (internal) IP range, for example IP range 192.168.0.1/24 use DNS server 192.168.0.1 for rDNS.

@db-EV commented on GitHub (Jun 19, 2019): rDNS lookups would be even better if it was possible to define a specific upstream server for a specific (internal) IP range, for example IP range 192.168.0.1/24 use DNS server 192.168.0.1 for rDNS.
Author
Owner

@ameshkov commented on GitHub (Jun 19, 2019):

@Termi79 makes sense. Could you please file a feature request about that?

@ameshkov commented on GitHub (Jun 19, 2019): @Termi79 makes sense. Could you please file a feature request about that?
Author
Owner

@nomandera commented on GitHub (Nov 14, 2019):

Reverse link as google makes this ticket much easier to find than the follow on Feature Request

https://github.com/AdguardTeam/AdGuardHome/issues/842

@nomandera commented on GitHub (Nov 14, 2019): Reverse link as google makes this ticket much easier to find than the follow on Feature Request https://github.com/AdguardTeam/AdGuardHome/issues/842
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/AdGuardHome#639
No description provided.