mirror of
https://github.com/AdguardTeam/AdGuardHome.git
synced 2026-03-04 00:01:12 -05:00
localhost "blocked" #703
Labels
No labels
P1: Critical
P2: High
P3: Medium
P4: Low
UI
bug
cannot reproduce
compatibility
dependencies
docker
documentation
duplicate
enhancement
enhancement
external libs
feature request
good first issue
help wanted
infrastructure
invalid
localization
needs investigation
performance
potential-duplicate
question
recurrent
research
snap
waiting for data
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/AdGuardHome#703
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Omoeba on GitHub (May 21, 2019).
Steps to reproduce
1.install adguard home and select all filters
2.set adguard home as system dns server for client(s)
3.look at query log and top blocked domains
Expected behavior
localhost should not be marked as blocked when a hosts file defines it as 127.0.0.1 and ::1; for example in hpHosts
Actual behavior
localhost is listed as the top blocked domain and the query log is filled by it
Your environment
@ameshkov commented on GitHub (May 22, 2019):
I am not sure if this can be considered a bug.
Every domain listed in any filter list is marked as blocked, why localhost should be an exception
@alexsannikov commented on GitHub (May 22, 2019):
Omoeba, delete localhost from any filter file.
Everything in filter files will be blocked.
I personally cleanup the hosts files from different sources before use, removing all the "localhost" records and replacing 127.0.0.1 -> 0.0.0.0
@Omoeba commented on GitHub (May 22, 2019):
localhost should be an exception because it is not blocked by defining the IP as 127.0.0.1 or ::1. The correct ip for localhost is 127.0.0.1 or ::1. For example, doubleclick.net is blocked by defining it as 127.0.0.1 when the IP is not.
@ameshkov commented on GitHub (May 23, 2019):
Pointing a hostname to 127.0.0.1 does not necessarily mean blocking. It just means that the client app will try to connect to 127.0.0.1 and if there's no one listening, the connection will fail.
Also, a hosts file can redefine
localhostand point it to some remote IP. So highlighting the fact that there's a line for it in the query log makes sense - you need to be aware of it.