Add support for filtering IP addresses #848

Closed
opened 2026-03-04 00:52:18 -05:00 by deekerman · 2 comments
Owner

Originally created by @DandelionSprout on GitHub (Aug 7, 2019).

Prerequisites

Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

Problem Description

After testing with 93.184.216.34, ||93.184.216.34, and (just to be fully certain) 93.184.216.34$network (as per this help doc for other versions of AdGuard), it seems to me personally that AdGuard Home does not yet support filtering domains based on their IP addresses, something that e.g. https://raw.githubusercontent.com/EnergizedProtection/block/master/extensions/ips/formats/list.txt base their lists around. So I hereby propose adding support for that.

Since the logger already registers the IP address of all queried domains, adding support for this doesn't seem to me to be as difficult as it'd otherwise be.

image

Proposed Solution

Simultaneously add support for IP address filtering, and making 93.184.216.34$network equivalent to 93.184.216.34 (or the other way around) to ensure compatibility with AdGuard's own lists.

Alternatives Considered

None that I can come up at the time of writing.

Additional Information

While only 24 IP-based filterlists are listed on FilterLists.com, https://github.com/firehol/blocklist-ipsets/ lists a whopping 365 such lists (and that's just the non-range ones), although most of them only cover very narrow uses. All in all, there's a decent amount of and support for IP-blocking lists out there.

Originally created by @DandelionSprout on GitHub (Aug 7, 2019). <!-- As an open-source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can. --> ### Prerequisites Please answer the following questions for yourself before submitting an issue. **YOU MAY DELETE THE PREREQUISITES SECTION.** - [x] I am running the latest version - [x] I checked the documentation and found no answer - [x] I checked to make sure that this issue has not already been filed ### Problem Description After testing with `93.184.216.34`, `||93.184.216.34`, and (just to be fully certain) `93.184.216.34$network` (as per [this help doc](https://kb.adguard.com/en/general/how-to-create-your-own-ad-filters#network-modifier) for other versions of AdGuard), it seems to me personally that AdGuard Home does not yet support filtering domains based on their IP addresses, something that e.g. https://raw.githubusercontent.com/EnergizedProtection/block/master/extensions/ips/formats/list.txt base their lists around. So I hereby propose adding support for that. Since the logger already registers the IP address of all queried domains, adding support for this doesn't seem to me to be as difficult as it'd otherwise be. ![image](https://user-images.githubusercontent.com/22780683/62666977-f8f36380-b985-11e9-9d58-264c71804a76.png) ### Proposed Solution Simultaneously add support for IP address filtering, and making `93.184.216.34$network` equivalent to `93.184.216.34` (or the other way around) to ensure compatibility with AdGuard's own lists. ### Alternatives Considered None that I can come up at the time of writing. ### Additional Information While only 24 IP-based filterlists are listed on FilterLists.com, https://github.com/firehol/blocklist-ipsets/ lists a whopping 365 such lists (and that's just the non-range ones), although most of them only cover very narrow uses. All in all, there's a decent amount of and support for IP-blocking lists out there.
deekerman 2026-03-04 00:52:18 -05:00
Author
Owner

@ameshkov commented on GitHub (Aug 8, 2019):

Tbh, I think this makes little sense to add this functionality to the DNS server.

However, when we finally implement the #391 this will be possible

@ameshkov commented on GitHub (Aug 8, 2019): Tbh, I think this makes little sense to add this functionality to the DNS server. However, when we finally implement the #391 this will be possible
Author
Owner

@DandelionSprout commented on GitHub (Jan 23, 2020):

Now that this has been accomplished for some 2 months by now, I figure it's time for me to close this.

@DandelionSprout commented on GitHub (Jan 23, 2020): Now that this has been accomplished for some 2 months by now, I figure it's time for me to close this.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/AdGuardHome#848
No description provided.