mirror of
https://github.com/AdguardTeam/AdGuardHome.git
synced 2026-03-04 00:01:12 -05:00
Add support for filtering IP addresses #848
Labels
No labels
P1: Critical
P2: High
P3: Medium
P4: Low
UI
bug
cannot reproduce
compatibility
dependencies
docker
documentation
duplicate
enhancement
enhancement
external libs
feature request
good first issue
help wanted
infrastructure
invalid
localization
needs investigation
performance
potential-duplicate
question
recurrent
research
snap
waiting for data
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/AdGuardHome#848
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @DandelionSprout on GitHub (Aug 7, 2019).
Prerequisites
Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.
Problem Description
After testing with
93.184.216.34,||93.184.216.34, and (just to be fully certain)93.184.216.34$network(as per this help doc for other versions of AdGuard), it seems to me personally that AdGuard Home does not yet support filtering domains based on their IP addresses, something that e.g. https://raw.githubusercontent.com/EnergizedProtection/block/master/extensions/ips/formats/list.txt base their lists around. So I hereby propose adding support for that.Since the logger already registers the IP address of all queried domains, adding support for this doesn't seem to me to be as difficult as it'd otherwise be.
Proposed Solution
Simultaneously add support for IP address filtering, and making
93.184.216.34$networkequivalent to93.184.216.34(or the other way around) to ensure compatibility with AdGuard's own lists.Alternatives Considered
None that I can come up at the time of writing.
Additional Information
While only 24 IP-based filterlists are listed on FilterLists.com, https://github.com/firehol/blocklist-ipsets/ lists a whopping 365 such lists (and that's just the non-range ones), although most of them only cover very narrow uses. All in all, there's a decent amount of and support for IP-blocking lists out there.
@ameshkov commented on GitHub (Aug 8, 2019):
Tbh, I think this makes little sense to add this functionality to the DNS server.
However, when we finally implement the #391 this will be possible
@DandelionSprout commented on GitHub (Jan 23, 2020):
Now that this has been accomplished for some 2 months by now, I figure it's time for me to close this.