mirror of
https://github.com/AdguardTeam/AdGuardHome.git
synced 2026-03-04 00:01:12 -05:00
Add support for "||example.org/*" #849
Labels
No labels
P1: Critical
P2: High
P3: Medium
P4: Low
UI
bug
cannot reproduce
compatibility
dependencies
docker
documentation
duplicate
enhancement
enhancement
external libs
feature request
good first issue
help wanted
infrastructure
invalid
localization
needs investigation
performance
potential-duplicate
question
recurrent
research
snap
waiting for data
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/AdGuardHome#849
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @DandelionSprout on GitHub (Aug 7, 2019).
Originally assigned to: @szolin on GitHub.
Prerequisites
Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.
Problem Description
||example.org/*won't work with AdGuard Home's current syntax support, despite how it seems to have the same functionality and coverage as what the fully supported||example.org^has. The most obvious case of the former being used in a filterlist, is https://raw.githubusercontent.com/bcye/Hello-Goodbye/master/filterlist.txt.Proposed Solution
Make
||example.org/*an equivalent of||example.org^, at least until the planned HTTP filtering has been implemented.Alternatives Considered
Some way to treat slashes followed solely by non-alphanumeric characters, as being whitespace themselves.
Additional Information
I used
||nrk.no/*to test this, asexample.orgdidn't seem to have enough content for a significant test of this.@ameshkov commented on GitHub (Aug 8, 2019):
Yup, thank you, this should be relatively easy to implement
@hesss5 commented on GitHub (Aug 26, 2019):
||.domain.com/redirect/ads
above can be implement too?
@DandelionSprout commented on GitHub (Aug 26, 2019):
(To hesss5) My personal understanding as a non-team-member, is that the AdGuard team didn't really think of adding support for anything with forward slashes, back when they created the domain filter system for the Android and DNS versions of AdGuard in 2015-ish. So it'd take exceptional circumstances to add workaround support for whichever types of slash-entries for at least the next few months.
@ameshkov commented on GitHub (Aug 27, 2019):
||.domain.com/redirect/adsOn the DNS-level you don't see the actual web requests, only domain names. So this is virtually impossible at this point.
This will be possible with the help of a MITM proxy when it's ready, see #391
@szolin commented on GitHub (Sep 26, 2019):
waiting for urlfilter v0.6.0
@ameshkov commented on GitHub (Oct 2, 2019):
Fixed by
github.com/AdguardTeam/AdGuardHome@c020c1d0af