Add support for "||example.org/*" #849

Closed
opened 2026-03-04 00:52:18 -05:00 by deekerman · 6 comments
Owner

Originally created by @DandelionSprout on GitHub (Aug 7, 2019).

Originally assigned to: @szolin on GitHub.

Prerequisites

Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

Problem Description

||example.org/* won't work with AdGuard Home's current syntax support, despite how it seems to have the same functionality and coverage as what the fully supported ||example.org^ has. The most obvious case of the former being used in a filterlist, is https://raw.githubusercontent.com/bcye/Hello-Goodbye/master/filterlist.txt.

Proposed Solution

Make ||example.org/* an equivalent of ||example.org^, at least until the planned HTTP filtering has been implemented.

Alternatives Considered

Some way to treat slashes followed solely by non-alphanumeric characters, as being whitespace themselves.

Additional Information

I used ||nrk.no/* to test this, as example.org didn't seem to have enough content for a significant test of this.

Originally created by @DandelionSprout on GitHub (Aug 7, 2019). Originally assigned to: @szolin on GitHub. <!-- As an open-source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can. --> ### Prerequisites Please answer the following questions for yourself before submitting an issue. **YOU MAY DELETE THE PREREQUISITES SECTION.** - [x] I am running the latest version - [ ] I checked the documentation and found no answer - [x] I checked to make sure that this issue has not already been filed ### Problem Description `||example.org/*` won't work with AdGuard Home's current syntax support, despite how it seems to have the same functionality and coverage as what the fully supported `||example.org^` has. The most obvious case of the former being used in a filterlist, is https://raw.githubusercontent.com/bcye/Hello-Goodbye/master/filterlist.txt. ### Proposed Solution Make `||example.org/*` an equivalent of `||example.org^`, at least until the planned HTTP filtering has been implemented. ### Alternatives Considered Some way to treat slashes followed solely by non-alphanumeric characters, as being whitespace themselves. ### Additional Information I used `||nrk.no/*` to test this, as `example.org` didn't seem to have enough content for a significant test of this.
deekerman 2026-03-04 00:52:18 -05:00
Author
Owner

@ameshkov commented on GitHub (Aug 8, 2019):

Yup, thank you, this should be relatively easy to implement

@ameshkov commented on GitHub (Aug 8, 2019): Yup, thank you, this should be relatively easy to implement
Author
Owner

@hesss5 commented on GitHub (Aug 26, 2019):

||.domain.com/redirect/ads
above can be implement too?

@hesss5 commented on GitHub (Aug 26, 2019): ||*.domain.com/redirect/ads* above can be implement too?
Author
Owner

@DandelionSprout commented on GitHub (Aug 26, 2019):

(To hesss5) My personal understanding as a non-team-member, is that the AdGuard team didn't really think of adding support for anything with forward slashes, back when they created the domain filter system for the Android and DNS versions of AdGuard in 2015-ish. So it'd take exceptional circumstances to add workaround support for whichever types of slash-entries for at least the next few months.

@DandelionSprout commented on GitHub (Aug 26, 2019): (To hesss5) My personal understanding as a non-team-member, is that the AdGuard team didn't really think of adding support for anything with forward slashes, back when they created the domain filter system for the Android and DNS versions of AdGuard in 2015-ish. So it'd take exceptional circumstances to add workaround support for whichever types of slash-entries for at least the next few months.
Author
Owner

@ameshkov commented on GitHub (Aug 27, 2019):

||.domain.com/redirect/ads

On the DNS-level you don't see the actual web requests, only domain names. So this is virtually impossible at this point.

This will be possible with the help of a MITM proxy when it's ready, see #391

@ameshkov commented on GitHub (Aug 27, 2019): `||.domain.com/redirect/ads` On the DNS-level you don't see the actual web requests, only domain names. So this is virtually impossible at this point. This will be possible with the help of a MITM proxy when it's ready, see #391
Author
Owner

@szolin commented on GitHub (Sep 26, 2019):

waiting for urlfilter v0.6.0

@szolin commented on GitHub (Sep 26, 2019): waiting for urlfilter v0.6.0
Author
Owner

@ameshkov commented on GitHub (Oct 2, 2019):

Fixed by github.com/AdguardTeam/AdGuardHome@c020c1d0af

@ameshkov commented on GitHub (Oct 2, 2019): Fixed by https://github.com/AdguardTeam/AdGuardHome/commit/c020c1d0afcaaac1015588ed98f34b59b0750bed
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/AdGuardHome#849
No description provided.