mirror of
https://github.com/Lidarr/Lidarr.git
synced 2026-03-03 00:26:58 -05:00
Allow ENV override for AcoustID values #2281
Labels
No labels
Area: API
Area: Database
Area: Db-migration
Area: Download Clients
Area: Extras
Area: Import Lists
Area: Indexer
Area: Metadata API
Area: Notifications
Area: Organizer
Area: Parser
Area: Scanning
Area: Tooling
Area: UI
Area: Unit Tests
Area: Update API
On Hold: MetadataAPI Blocking
Priority: High
Priority: Low
Priority: Medium
Status: Accepted
Status: Cannot Reproduce
Status: Confirmed
Status: Don't Merge
Status: Help Wanted
Status: In Progress
Status: Info Needed
Status: Investigating
Status: Logs Needed
Status: Maybe One Day
Status: Needs Triage
Status: On Hold
Status: Ready for Review
Status: Unlikely
Status: Waiting for OP
Status: Won't Fix
Type: Bug
Type: Documentation
Type: Duplicate
Type: Enhancement
Type: Enhancement
Type: External Bug
Type: Feature Request
Type: Regression
Type: Support
Type: Support.
conflict
conflict
no-conflict
not-pulled
radarr-pull
readarr-pull
sonarr upstream
sonarr-pull
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Lidarr-Lidarr#2281
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @DeftNerd on GitHub (Oct 5, 2022).
Is there an existing issue for this?
Is your feature request related to a problem? Please describe
api.acoustid.org keeps having more and more timeouts. I'm not sure if it's the Lidarr API key that's being throttled or the API endpoint itself. There are proxy services available such as acoustid.plex.tv, and self-hosted docker proxies such as acoustid/docker-https-proxy available to cache the data. It would be a benefit if they could be utilized.
It's even possible to download the whole database (just a few gigs in size) to locally host it for quick local responses.
Describe the solution you'd like
I think it would be useful to allow users to set an ENV variable to override some of the values in FingerprintingService.cs such as the API URL, API Key, and timeout value
Perhaps ACOUSTID_URL, ACOUSTID_KEY, and ACOUSTID_TIMEOUT?
A slightly more advanced feature would be to allow the default hard-coded values to take effect if the ENV set values fail for some reason. It would be nice to have that as a fallback.
Describe alternatives you've considered
Overriding DNS locally, but there are complications with HTTPS enforcement.
Anything else?
#3009
#1821
AB#3874
@Qstick commented on GitHub (Oct 21, 2022):
Good thoughts. Let us take a look at some options
@ovizii commented on GitHub (Jan 31, 2023):
I have an acoustid api key I am using with my beets container but I can't seem to find an option to let lidarr use this same api key.
@ovizii commented on GitHub (Jan 31, 2023):
This is what my error looks like: