mirror of
https://github.com/Lidarr/Lidarr.git
synced 2026-03-02 22:56:57 -05:00
[BUG]: Leading ellipsis for nested folder names replaced with dot on import #1764
Labels
No labels
Area: API
Area: Database
Area: Db-migration
Area: Download Clients
Area: Extras
Area: Import Lists
Area: Indexer
Area: Metadata API
Area: Notifications
Area: Organizer
Area: Parser
Area: Scanning
Area: Tooling
Area: UI
Area: Unit Tests
Area: Update API
On Hold: MetadataAPI Blocking
Priority: High
Priority: Low
Priority: Medium
Status: Accepted
Status: Cannot Reproduce
Status: Confirmed
Status: Don't Merge
Status: Help Wanted
Status: In Progress
Status: Info Needed
Status: Investigating
Status: Logs Needed
Status: Maybe One Day
Status: Needs Triage
Status: On Hold
Status: Ready for Review
Status: Unlikely
Status: Waiting for OP
Status: Won't Fix
Type: Bug
Type: Documentation
Type: Duplicate
Type: Enhancement
Type: Enhancement
Type: External Bug
Type: Feature Request
Type: Regression
Type: Support
Type: Support.
conflict
conflict
no-conflict
not-pulled
radarr-pull
readarr-pull
sonarr upstream
sonarr-pull
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Lidarr#1764
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @gaizaharduz on GitHub (Aug 21, 2021).
Is there an existing issue for this?
Current Behavior
I saw this issue was reported and fixed before in https://github.com/lidarr/Lidarr/issues/604, but I think it was probably reintroduced with the recently added nested path feature.
Using a track format such as:
When importing an album with the name
...My Album..., it gets renamed to:Expected Behavior
Despite the name being a bit weird, the main issue is that the leading dot of course causes the album folder to be viewed as hidden, and ultimately ignored by Lidarr on re-scan (and also other software such as Jellyfin).
Steps To Reproduce
No response
Environment
What branch are you running?
Master
Anything else?
I think that calling
CleanFolderNameinstead of using theFileNameCleanupRegexdirectly here would at least solve the hidden file issue:github.com/Lidarr/Lidarr@187672b183/src/NzbDrone.Core/Organizer/FileNameBuilder.cs (L134)I also noticed that Radarr previously had a similar issue and introduced a test case, which may be a good idea to prevent reoccurrence: https://github.com/Radarr/Radarr/pull/4509/commits/b336cb0b77feb596802128de43bb8173e169f7fa
AB#1483
@scottfridwin commented on GitHub (Aug 16, 2022):
Just recently ran into the issue in 2 different ways:
To me, the second issue is more concerning since it essentially results in those files disappearing. Lidarr will try to query indexers for replacements and potentially download over and over again.
@chrisjameschamp commented on GitHub (Nov 3, 2022):
What's the status on this being fixed, I see over a year ago it is marked as fixed but never merged
@ohsnapword commented on GitHub (Dec 20, 2022):
I am still seeing this behavior in version 1.1.1.2762.