Update metadata only after seeding is complete #2522

Open
opened 2026-02-20 02:09:40 -05:00 by deekerman · 1 comment
Owner

Originally created by @jaja360 on GitHub (Dec 4, 2022).

Is there an existing issue for this?

  • I have searched the existing open and closed issues

Some other issues mention the problem when a file still being seeded gets imported by Lidarr (using hardlinks) when the "Tag Audio Files with Metadata" option is enabled, resulting in a corrupt piece in the torrent client. See, e.g., Issue 1016

Describe the solution you'd like

I think a good solution would be to delay the metadata tagging until after the seeding is complete (e.g., until after the target Seed Ratio or Seed Time has been reached, or the torrent has been manually removed from the torrent client).

With this solution we would:

  • Prevent "Corrupt pieces"
  • Allow for both the hardlink and "Tag metadata" options to be enabled at the same time without problems
  • Make sure the tags will eventually be synced with musicbrainz (when seeding is complete).

Describe alternatives you've considered

  • Alternative 1: Status quo
    • Bad because users get many "corrupt pieces" message without knowing why.
  • Alternative 2: Add a warning message when the hardlink and the Tag metadata options are both active
    • At least the users would be aware of the problem, but it does not "solve" the problem per se.
    • Users would have to manually disable hardlinks (takes lot of space on drive for large library)
    • Or users would have to manually disable metadata (and probably forget to sync the metadata on the the albums when their seeding is complete)

Anything else?

Not really.

AB#4309

Originally created by @jaja360 on GitHub (Dec 4, 2022). ### Is there an existing issue for this? - [X] I have searched the existing open and closed issues ### Is your feature request related to a problem? Please describe Some other issues mention the problem when a file still being seeded gets imported by Lidarr (using hardlinks) when the "Tag Audio Files with Metadata" option is enabled, resulting in a corrupt piece in the torrent client. See, e.g., [Issue 1016](https://github.com/Lidarr/Lidarr/issues/1016) ### Describe the solution you'd like I think a good solution would be to delay the metadata tagging until after the seeding is complete (e.g., until after the target `Seed Ratio` or `Seed Time` has been reached, or the torrent has been manually removed from the torrent client). With this solution we would: - Prevent "Corrupt pieces" - Allow for both the hardlink and "Tag metadata" options to be enabled at the same time without problems - Make sure the tags will eventually be synced with musicbrainz (when seeding is complete). ### Describe alternatives you've considered - Alternative 1: Status quo - Bad because users get many "corrupt pieces" message without knowing why. - Alternative 2: Add a warning message when the `hardlink` and the `Tag metadata` options are both active - At least the users would be aware of the problem, but it does not "solve" the problem per se. - Users would have to manually disable hardlinks (takes lot of space on drive for large library) - Or users would have to manually disable metadata (and probably forget to sync the metadata on the the albums when their seeding is complete) ### Anything else? Not really. [AB#4309](https://dev.azure.com/Servarr/7ab38f4e-5a57-4d70-84f4-94dd9bc5d6df/_workitems/edit/4309)
Author
Owner

@PearsonFlyer commented on GitHub (Feb 3, 2023):

I think it would be useful to have a heathcheck warning is both the hardlink and tag metadata options are checked. At least it would warn the users and maybe save someone some trouble.

@PearsonFlyer commented on GitHub (Feb 3, 2023): I think it would be useful to have a heathcheck warning is both the hardlink and tag metadata options are checked. At least it would warn the users and maybe save someone some trouble.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/Lidarr#2522
No description provided.