mirror of
https://github.com/Lidarr/Lidarr.git
synced 2026-03-02 22:56:57 -05:00
Release rejected - Better indication what exactly caused it #3327
Labels
No labels
Area: API
Area: Database
Area: Db-migration
Area: Download Clients
Area: Extras
Area: Import Lists
Area: Indexer
Area: Metadata API
Area: Notifications
Area: Organizer
Area: Parser
Area: Scanning
Area: Tooling
Area: UI
Area: Unit Tests
Area: Update API
On Hold: MetadataAPI Blocking
Priority: High
Priority: Low
Priority: Medium
Status: Accepted
Status: Cannot Reproduce
Status: Confirmed
Status: Don't Merge
Status: Help Wanted
Status: In Progress
Status: Info Needed
Status: Investigating
Status: Logs Needed
Status: Maybe One Day
Status: Needs Triage
Status: On Hold
Status: Ready for Review
Status: Unlikely
Status: Waiting for OP
Status: Won't Fix
Type: Bug
Type: Documentation
Type: Duplicate
Type: Enhancement
Type: Enhancement
Type: External Bug
Type: Feature Request
Type: Regression
Type: Support
Type: Support.
conflict
conflict
no-conflict
not-pulled
radarr-pull
readarr-pull
sonarr upstream
sonarr-pull
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Lidarr#3327
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @PeterCodar on GitHub (Nov 2, 2023).
Is there an existing issue for this?
Is your feature request related to a problem? Please describe
I'm not sure, maybe it is related to https://github.com/Lidarr/Lidarr/issues/2632
As you can see in this screenshot, a found possible album match has been rejected by two causes:
The size and my custom format.
This FR is about the size.
If the rejection is based on quality settings: Which quality exactly is causing this?
There is no obvious setting I can find for "maximum allowed 116,1 MB"?
Describe the solution you'd like
Indicate that the setting - for example - "MP3-VBR-V2" with the current settings is causing the rejection.
You could show it as the same "MP3-VBR-V2" label. Just color the background red - for example.

Describe alternatives you've considered
Alternative solution:
Let the user disable the entire quality settings if an "Interactive Search" is used.
Anything else?
Nothing else.
@bakerboy448 commented on GitHub (Nov 2, 2023):
The Quality sizes is based on the bitrate for the quality selected which is then multiplied by the run time as indicated in the UI
the quality is clearly displayed as well, so not sure what this ask is?
@PeterCodar commented on GitHub (Nov 2, 2023):
@bakerboy448
If it "is clearly displayed":
Please tell me from the above screenshot which quality setting is causing the rejection and has to be modified?
@mynameisbogdan commented on GitHub (Nov 2, 2023):
Your popover is hiding the detected quality.
@bakerboy448 commented on GitHub (Nov 2, 2023):
The reject hover over is blocking the quality of the album I believe, so it's not possible from your screenshot to say what quality the album is
Similarly your quality sizes cut off which quality
@PeterCodar commented on GitHub (Nov 2, 2023):
🤦♂️ Of course, you are both right!
Without hovering over the exlamation mark, I can now also see it. 🧐

I'm sorry!