mirror of
https://github.com/Lidarr/Lidarr.git
synced 2026-03-02 22:56:57 -05:00
Extend updated extra file import functionality to organize/rename action #4024
Labels
No labels
Area: API
Area: Database
Area: Db-migration
Area: Download Clients
Area: Extras
Area: Import Lists
Area: Indexer
Area: Metadata API
Area: Notifications
Area: Organizer
Area: Parser
Area: Scanning
Area: Tooling
Area: UI
Area: Unit Tests
Area: Update API
On Hold: MetadataAPI Blocking
Priority: High
Priority: Low
Priority: Medium
Status: Accepted
Status: Cannot Reproduce
Status: Confirmed
Status: Don't Merge
Status: Help Wanted
Status: In Progress
Status: Info Needed
Status: Investigating
Status: Logs Needed
Status: Maybe One Day
Status: Needs Triage
Status: On Hold
Status: Ready for Review
Status: Unlikely
Status: Waiting for OP
Status: Won't Fix
Type: Bug
Type: Documentation
Type: Duplicate
Type: Enhancement
Type: Enhancement
Type: External Bug
Type: Feature Request
Type: Regression
Type: Support
Type: Support.
conflict
conflict
no-conflict
not-pulled
radarr-pull
readarr-pull
sonarr upstream
sonarr-pull
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Lidarr#4024
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @anthonyrom on GitHub (Oct 27, 2024).
Is there an existing issue for this?
Is your feature request related to a problem? Please describe
Although extra file imports will be "fixed" by #4370, extra file rules are not applied when running the rename/organize action. This mainly applies to configuring Lidarr with an existing library. As-is, running the organize/rename action will leave those extra files in the old directory.
Describe the solution you'd like
It would make sense to apply the user's choice of extra file handling on import to the rename/organize action. This would greatly smooth the process of setting up Lidarr for existing libraries, and seems like a sensible default behavior.
Describe alternatives you've considered
Currently this case must be handled manually by the user. Creating a script to parse your existing music library and move files is not straightforward, since the script would need to know the destination folder for each source folder, i.e., would need to somehow interface with Lidarr to match the source folder to a release and then get the correct destination path.
Anything else?
I'm happy to work on this feature but would like to open this up to see if there is interest first.
@tty418 commented on GitHub (Nov 29, 2024):
Hey @anthonyrom I am still waiting for a review of my PR. I saw you mentioned an issue with the implementation, could you elaborate on that? From what I remember, I reworked the implementation to handle various common cases and also included rename/reorg handling. So if memory serves me right, moving extras should work.
A quick list of repro steps and maybe a screenshot or two would help! Also can you double-check which version you are using? There might be a few similarly tagged images, so make sure that you are on this one:
ghcr.io/linuxserver-labs/prarr:lidarr-extras-for-albums-2.3.1.4170(at https://github.com/linuxserver-labs/prarr/pkgs/container/prarr/208635980?tag=lidarr-extras-for-albums-2.3.1.4170 )Regards!