starred/PeerTube

Fork 0

mirror of https://github.com/Chocobozzz/PeerTube.git synced 2026-03-02 22:57:11 -05:00

Add complete username on account page #1520

New issue

Closed

opened 2026-02-22 05:43:17 -05:00 by deekerman · 8 comments

deekerman commented

2026-02-22 05:43:17 -05:00

Owner

Originally created by @valvin1 on GitHub (May 24, 2019).

What happened?
When I want to add an account on my friendica instance I need to have a complete AP username @username@server.tld but I can't find it on account page. I can only see "username" whitout server.tld.

What do you expect to happen instead?
Having near the user (in small) a complete username @username@server.tld or username@server.tld

Steps to reproduce:
In my case I was watching a video on Touhoppai instance
I click on user who posted the video and i'm redirected on its account / video page
I can only copy username : touhoppai but not its complete username @touhoppai@peertube.touhoppai.moe

Additional information

PeerTube version or URL: v1.3.0-rc2
Browser name/version:Firefox 67

Originally created by @valvin1 on GitHub (May 24, 2019). **What happened?** When I want to add an account on my friendica instance I need to have a complete AP username `@username@server.tld` but I can't find it on account page. I can only see "username" whitout server.tld. **What do you expect to happen instead?** Having near the user (in small) a complete username `@username@server.tld` or `username@server.tld` **Steps to reproduce:** In my case I was watching a video on [Touhoppai instance](https://peertube.touhoppai.moe/videos/watch/8a9a054a-b1ac-4658-b363-e3212bc52054) I click on user who posted the video and i'm redirected on its [account / video page](https://peertube.touhoppai.moe/accounts/touhoppai/videos) I can only copy username : `touhoppai` but not its complete username `@touhoppai@peertube.touhoppai.moe` **Additional information** * PeerTube version or URL: v1.3.0-rc2 * Browser name/version:Firefox 67

deekerman

2026-02-22 05:43:17 -05:00

closed this issue
added the
Type: Feature Request ✨

UI
labels

deekerman commented

2026-02-22 05:43:21 -05:00

Author

Owner

@NassimBounouas commented on GitHub (May 25, 2019):

Hello,

I guess that the complete username is not displayed when the account is displayed from its original instance. In this case, the name is truncated.

What I found :

The account complete name is displayed there.
This field is created there and the function called is this one.

This is, I guess, the explanation for this difference between Touhoppai profile on its instance and this profile on p2p legal instance.

Is this behavior normal @rigelk or can I do a PR with a modification ?

Thank you !

@NassimBounouas commented on GitHub (May 25, 2019): Hello, I guess that the complete username is not displayed when the account is displayed from its original instance. In this case, the name is truncated. **What I found :** - The account complete name is displayed [there](https://github.com/Chocobozzz/PeerTube/blob/develop/client/src/app/%2Baccounts/accounts.component.html#L10). - This field is created [there](https://github.com/Chocobozzz/PeerTube/blob/develop/client/src/app/shared/account/account.model.ts#L21) and the function called is [this one](https://github.com/Chocobozzz/PeerTube/blob/develop/client/src/app/shared/actor/actor.model.ts#L31). This is, I guess, the explanation for this difference between [Touhoppai profile on its instance](https://peertube.touhoppai.moe/accounts/touhoppai/videos) and [this profile on p2p legal instance](https://tube.p2p.legal/accounts/linux@peertube.mastodon.host/videos). Is this behavior normal @rigelk or can I do a PR with a modification ? Thank you !

deekerman commented

2026-02-22 05:43:21 -05:00

Author

Owner

@Chocobozzz commented on GitHub (May 27, 2019):

Hi,

This behaviour is intended to easily differentiate between a local account and a remote account. I think we should keep this behaviour, except on the account page. What do you think?

@Chocobozzz commented on GitHub (May 27, 2019): Hi, This behaviour is intended to easily differentiate between a local account and a remote account. I think we should keep this behaviour, except on the account page. What do you think?

deekerman commented

2026-02-22 05:43:21 -05:00

Author

Owner

@NassimBounouas commented on GitHub (May 30, 2019):

Hi @Chocobozzz !

Thank you for your response, It seems that the static function I pointed (this one) is the one called for the account page rendering as I showed in my previous message and the same one is called for miniatures display there and there.

I think the best suggestion we can keep is yours. Maybe, can we add a parameter to this function in order to force the host to be added (in the account page) by adding this boolean parameter to skip the host verification (Line 31 on actor.model.ts) and let the previous behavior on other use case.

@NassimBounouas commented on GitHub (May 30, 2019): Hi @Chocobozzz ! Thank you for your response, It seems that the static function I pointed [(this one)](https://github.com/Chocobozzz/PeerTube/blob/develop/client/src/app/shared/actor/actor.model.ts#L31) is the one called for the account page rendering as I showed in my previous message and the same one is called for miniatures display [there](https://github.com/Chocobozzz/PeerTube/blob/3a0fb65c61f80b510bce979a45d59d17948745e8/client/src/app/shared/video/video.model.ts#L112) and [there](https://github.com/Chocobozzz/PeerTube/blob/develop/client/src/app/shared/video/video-miniature.component.html#L26). I think the best suggestion we can keep is yours. Maybe, can we add a parameter to this function in order to force the host to be added (in the account page) by adding this boolean parameter to skip the host verification (Line 31 on actor.model.ts) and let the previous behavior on other use case.

deekerman commented

2026-02-22 05:43:21 -05:00

Author

Owner

@valvin1 commented on GitHub (May 30, 2019):

I agree only the accout / user page is enought. On other pages it makes sense to have only the username.
It is what I imagined when writing this request 😃

@valvin1 commented on GitHub (May 30, 2019): I agree only the accout / user page is enought. On other pages it makes sense to have only the username. It is what I imagined when writing this request 😃

deekerman commented

2026-02-22 05:43:21 -05:00

Author

Owner

@bolikahult commented on GitHub (May 31, 2019):

Little suggestion : if this complete username is displayed to be copied, why not add a "copy button" right after ? (like this example)

@bolikahult commented on GitHub (May 31, 2019): Little suggestion : if this complete username is displayed _to be copied_, why not add a "copy button" right after ? (like this [example](https://www.flaticon.com/free-icon/copy-outlined-circular-button_52847))

deekerman commented

2026-02-22 05:43:21 -05:00

Author

Owner

@NassimBounouas commented on GitHub (Jun 7, 2019):

Hi,
@bolikahult indeed your suggestion is wise. A "copy button" could provide a better user experience than an old plain text field to copy the complete username.

@NassimBounouas commented on GitHub (Jun 7, 2019): Hi, @bolikahult indeed your suggestion is wise. A "copy button" could provide a better user experience than an old plain text field to copy the complete username.

deekerman commented

2026-02-22 05:43:22 -05:00

Author

Owner

@Chocobozzz commented on GitHub (Jun 19, 2019):

Closing since the suggestion in https://github.com/Chocobozzz/PeerTube/issues/1843#issuecomment-497613863 was implemented by @NassimBounouas.

@Chocobozzz commented on GitHub (Jun 19, 2019): Closing since the suggestion in https://github.com/Chocobozzz/PeerTube/issues/1843#issuecomment-497613863 was implemented by @NassimBounouas.

deekerman commented

2026-02-22 05:43:22 -05:00

Author

Owner

@valvin1 commented on GitHub (Oct 25, 2019):

Thank you (a bit late) @NassimBounouas @Chocobozzz for the implementation :)

@valvin1 commented on GitHub (Oct 25, 2019): Thank you (a bit late) @NassimBounouas @Chocobozzz for the implementation :)