mirror of
https://github.com/Chocobozzz/PeerTube.git
synced 2026-03-02 22:57:11 -05:00
Runners should be capable of chunked upload. #5078
Labels
No labels
Component: Accessibility
Component: Administration
Component: Auth
Component: CLI
Component: Channels
Component: Chapters
Component: Comments
Component: Custom Markdown
Component: Docker 🐳
Component: Documentation 📚
Component: Email
Component: Embed
Component: Federation 🎡
Component: Import/Export
Component: Live
Component: Metadata
Component: Mobile
Component: Moderation :godmode:
Component: Notifications
Component: Object storage
Component: Observability
Component: PeerTube Plugin 📦
Component: Player ⏯️
Component: Playlist
Component: Recommendation
Component: Redundancy
Component: Registration
Component: Runners
Component: SEO
Component: Search
Component: Security
Component: Stats
Component: Studio
Component: Studio
Component: Subscriptions
Component: Subtitles 💬
Component: Transcoding
Component: Upload
Component: Video Import
Component: i18n 🔡
Priority: High
Priority: Low
Priority: Roadmap
Status: Blocked ✋
Status: In Progress 🔜
Status: To Reproduce
Status: Waiting for answer
Template not filled
Type: Bug 🐛
Type: Discussion 💭
Type: Discussion 💭
Type: Duplicate ➿
Type: Feature Request ✨
Type: Maintenance 👷♀️
Type: Performance
Type: Question
UI
good first issue
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/PeerTube#5078
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Kinuseka on GitHub (Jul 13, 2023).
Describe the problem to be solved
When a runner finishes its job it uploads back its file contents to the main server, however this non chunked format might pose issues to specific environment especially those behind a cloudflare proxy.
Instances running behind cloudflare might have issues with runners sending files back to the main server due to upload limitation on free tier locked to 100MB per connection (200MB pro, 512MB enterprise) which will return 413 error if the request had exceeded that amount.
Describe the solution you would like
The solution is that peertube runner should not upload the file in one connection and should be able to upload them in chunks.
Although this solution is not only limited to just solving cloudflare alone, it could also make runners robust to connection errors by simply retrying that chunk again if it ever there are some connection issues.
@alvensleben commented on GitHub (Oct 15, 2024):
Are there any updates on this feature? I'm currently facing an issue with peertube-runner and Cloudflare, I have to disable the protection in case I use remote transcoding. The main server won't be able to handle the load, unfortunately. I can't come up with a proper solution (I can't just disable Cloudflare's protection fully, I need it).