mirror of
https://github.com/Chocobozzz/PeerTube.git
synced 2026-03-02 22:57:11 -05:00
Support copy codecs in peertube runner #5663
Labels
No labels
Component: Accessibility
Component: Administration
Component: Auth
Component: CLI
Component: Channels
Component: Chapters
Component: Comments
Component: Custom Markdown
Component: Docker 🐳
Component: Documentation 📚
Component: Email
Component: Embed
Component: Federation 🎡
Component: Import/Export
Component: Live
Component: Metadata
Component: Mobile
Component: Moderation :godmode:
Component: Notifications
Component: Object storage
Component: Observability
Component: PeerTube Plugin 📦
Component: Player ⏯️
Component: Playlist
Component: Recommendation
Component: Redundancy
Component: Registration
Component: Runners
Component: SEO
Component: Search
Component: Security
Component: Stats
Component: Studio
Component: Studio
Component: Subscriptions
Component: Subtitles 💬
Component: Transcoding
Component: Upload
Component: Video Import
Component: i18n 🔡
Priority: High
Priority: Low
Priority: Roadmap
Status: Blocked ✋
Status: In Progress 🔜
Status: To Reproduce
Status: Waiting for answer
Template not filled
Type: Bug 🐛
Type: Discussion 💭
Type: Discussion 💭
Type: Duplicate ➿
Type: Feature Request ✨
Type: Maintenance 👷♀️
Type: Performance
Type: Question
UI
good first issue
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/PeerTube#5663
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ilfarpro on GitHub (Aug 7, 2024).
Describe the current behavior
I'm sorry. this could be not a bug or maybe just not implemented yet...
When I use Peertube without runner it can do job
optimize-to-web-videoand next to itnew-resolution-to-hlsjob with"copyCodecs": trueoption. Peertube runner can't do that for some reason. It leads to significant increase in time because runner should encode original resolution 2 times:Please take a look at screenshosts to see more.
This is how Peertube without runner behaves. It can copy codecs and save a ton of time.

But Peertube runner encodes 2 times the same resolution and it takes 2x time.

Maybe it's related to this line of code.
github.com/Chocobozzz/PeerTube@da992cbcab/apps/peertube-runner/src/server/process/shared/process-vod.ts (L118)Steps to reproduce
Describe the expected behavior
I expect peertube runner to copy codecs for highest resolution when it does it's HLS version. Peertube already can do that, let's make runner be able to do it too, please 🙏
Additional information