starred/Prowlarr

Fork 0

mirror of https://github.com/Prowlarr/Prowlarr.git synced 2026-03-02 22:57:22 -05:00

PTP: Add grouping=0 to json feed URL #836

New issue

Closed

opened 2026-02-20 10:04:09 -05:00 by deekerman · 4 comments

deekerman commented

2026-02-20 10:04:09 -05:00

Owner

Originally created by @jonoff on GitHub (Apr 9, 2023).

Is there an existing issue for this?

I have searched the existing open and closed issues

PTP's json page by default groups objects (according to staff), I verified by disabling my user preferences and still see json grouped results. This grouping allows for older releases to be grabbed from the 'RSS' feed anytime in the future, as they populate whenever any item of the group is uploaded.

Describe the solution you'd like

By adding a setting a 'grouping' parameter to 0, here: github.com/Prowlarr/Prowlarr@b7fcdb5356/src/NzbDrone.Core/Indexers/Definitions/PassThePopcorn/PassThePopcornRequestGenerator.cs (L42)

It would prevent older releases being grabbed due to grouping.

Describe alternatives you've considered

I tried disabling my personal preferences, but they don't seem to affect the json feed, the json default is for grouping to be enabled.

Anything else?

Also applied to radarr.

Originally created by @jonoff on GitHub (Apr 9, 2023). ### Is there an existing issue for this? - [X] I have searched the existing open and closed issues ### Is your feature request related to a problem? Please describe PTP's json page by default groups objects (according to staff), I verified by disabling my user preferences and still see json grouped results. This grouping allows for older releases to be grabbed from the 'RSS' feed anytime in the future, as they populate whenever any item of the group is uploaded. ### Describe the solution you'd like By adding a setting a 'grouping' parameter to 0, here: https://github.com/Prowlarr/Prowlarr/blob/b7fcdb5356cfa097a2099c8c1ed1b4b7afd94675/src/NzbDrone.Core/Indexers/Definitions/PassThePopcorn/PassThePopcornRequestGenerator.cs#L42 It would prevent older releases being grabbed due to grouping. ### Describe alternatives you've considered I tried disabling my personal preferences, but they don't seem to affect the json feed, the json default is for grouping to be enabled. ### Anything else? Also applied to radarr.

deekerman

2026-02-20 10:04:09 -05:00

closed this issue
added the
Type: Feature Request

Status: Needs Triage

Status: Indexer - need invite
labels

deekerman commented

2026-02-20 10:04:11 -05:00

Author

Owner

@mynameisbogdan commented on GitHub (Apr 9, 2023):

You can try to make the change yourself, but you'll have to change the parser to match it.

github.com/Prowlarr/Prowlarr@b7fcdb5356/src/NzbDrone.Core/Indexers/Definitions/PassThePopcorn/PassThePopcornParser.cs (L68-L114)

github.com/Prowlarr/Prowlarr@b7fcdb5356/src/NzbDrone.Core/Indexers/Definitions/PassThePopcorn/PassThePopcornApi.cs

@mynameisbogdan commented on GitHub (Apr 9, 2023): You can try to make the change yourself, but you'll have to change the parser to match it. https://github.com/Prowlarr/Prowlarr/blob/b7fcdb5356cfa097a2099c8c1ed1b4b7afd94675/src/NzbDrone.Core/Indexers/Definitions/PassThePopcorn/PassThePopcornParser.cs#L68-L114 https://github.com/Prowlarr/Prowlarr/blob/b7fcdb5356cfa097a2099c8c1ed1b4b7afd94675/src/NzbDrone.Core/Indexers/Definitions/PassThePopcorn/PassThePopcornApi.cs

deekerman commented

2026-02-20 10:04:11 -05:00

Author

Owner

@jonoff commented on GitHub (Apr 9, 2023):

What exactly would need to change in the parser?

My suggested fix would only add a flag to the json request, which limits the number of responses to be only include releases that were recently uploaded, the body of each response shouldn't change at all.

After github.com/Prowlarr/Prowlarr@b7fcdb5356/src/NzbDrone.Core/Indexers/Definitions/PassThePopcorn/PassThePopcornRequestGenerator.cs (L42-L46)
it would just be an additional line:
{ "grouping", 0}

@jonoff commented on GitHub (Apr 9, 2023): What exactly would need to change in the parser? My suggested fix would only add a flag to the json request, which limits the number of responses to be only include releases that were recently uploaded, the body of each response shouldn't change at all. After https://github.com/Prowlarr/Prowlarr/blob/b7fcdb5356cfa097a2099c8c1ed1b4b7afd94675/src/NzbDrone.Core/Indexers/Definitions/PassThePopcorn/PassThePopcornRequestGenerator.cs#L42-L46 it would just be an additional line: ` { "grouping", 0}`

deekerman commented

2026-02-20 10:04:11 -05:00

Author

Owner

@mynameisbogdan commented on GitHub (Apr 9, 2023):

My suggested fix would only add a flag to the json request, which limits the number of responses to be only include releases that were recently uploaded, the body of each response shouldn't change at all.

Are you 100% sure of this claim?

[v10.0.0.36952] FluentValidation.ValidationException: Validation failed:
 -- : Unable to connect to indexer, check the log above the ValidationFailure for more details. Error converting value {null} to type 'System.Int32'. Path 'Movies[0].TotalLeechers', line 1, position 264.

So the parser needs updated as well. :)

@mynameisbogdan commented on GitHub (Apr 9, 2023): > My suggested fix would only add a flag to the json request, which limits the number of responses to be only include releases that were recently uploaded, the body of each response shouldn't change at all. Are you 100% sure of this claim? ``` [v10.0.0.36952] FluentValidation.ValidationException: Validation failed: -- : Unable to connect to indexer, check the log above the ValidationFailure for more details. Error converting value {null} to type 'System.Int32'. Path 'Movies[0].TotalLeechers', line 1, position 264. ``` So the parser needs updated as well. :)

deekerman commented

2026-02-20 10:04:11 -05:00

Author

Owner

@jonoff commented on GitHub (Apr 9, 2023):

Ah, my mistake, I see what you mean, as some group fields do get set to null. Will look into it more.

Example from a group of 2: https://privatebin.net/?26b96a5b4e7c7b7f=#FUXMoRnMsRQYNtMBR7cHMXYAUMpJDxoPXLxU1mPzJuib

@jonoff commented on GitHub (Apr 9, 2023): Ah, my mistake, I see what you mean, as some group fields do get set to null. Will look into it more. Example from a group of 2: https://privatebin.net/?26b96a5b4e7c7b7f=#FUXMoRnMsRQYNtMBR7cHMXYAUMpJDxoPXLxU1mPzJuib