mirror of
https://github.com/Radarr/Radarr.git
synced 2026-03-02 22:57:34 -05:00
Change old movie file torrent label on upgrade #6462
Labels
No labels
Area: API
Area: Database
Area: Db-migration
Area: Download Clients
Area: Extras
Area: Import Lists
Area: Indexer
Area: Metadata API
Area: Notifications
Area: Organizer
Area: Parser
Area: Scanning
Area: Tooling
Area: UI
Area: Unit Tests
On Hold: MetadataAPI Blocking
On Hold: MetadataAPI Blocking
Priority: High
Priority: Low
Priority: Medium
Status: Accepted
Status: Cannot Reproduce
Status: Confirmed
Status: Help Wanted
Status: In Progress
Status: Indexer - need invite
Status: Info Needed
Status: Investigating
Status: Logs Needed
Status: Maybe One Day
Status: Needs Triage
Status: On Hold
Status: Ready for Review
Status: Unlikely
Status: Waiting for OP
Status: Won't Fix
Type: Bug
Type: Documentation
Type: Duplicate
Type: Enhancement
Type: External Bug
Type: Feature Request
Type: Regression
Type: Support
Type: Support.
conflict
lidarr-pull
no-conflict
not-pulled
readarr-pull
readarr-pull
sonarr upstream
sonarr-pull
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Radarr#6462
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @peloyeje on GitHub (Apr 1, 2022).
Is there an existing issue for this?
Is your feature request related to a problem? Please describe
When Radarr fetches and downloads a new release as part of a quality upgrade, the trumped movie file is deleted from the root folder but is left as-is in the download client (in my case rtorrent). This behavior is very sensible, but it means that I can find multiple versions for a given movie in my torrent client, without being able to quickly see which one is currently "active" in Radarr.
Describe the solution you'd like
IMHO it would be useful to be able to set a "post-upgrade label" in the Download client config modal (in the same fashion as "post-import"), so trumped movie files are grouped together under a distinct tag.
This would make it possible to add some auto cleaning rules in the torrent client such as:
Describe alternatives you've considered
Honestly Idk but any idea is welcome :)
Anything else?
N/A
AB#2891
@bakerboy448 commented on GitHub (Apr 1, 2022):
Basically something similar to what Qbit Manage already does with checking if a file is hardlinked and adjusting accordingly?
Given how versatile rtorrent is, you can probably custom script the same in the client itself.
this seems like a lot of overhead for something that isn't particularly in the scope of *arrs - managing your torrent client and torrents.
@peloyeje commented on GitHub (Apr 1, 2022):
Hey,
Didn't know about Qbit manage but yeah exactly like that!
Regarding the custom script alternative, it is definitely doable, but I was hoping the implementation of this feature request could rely heavily on the logic of the "post-import label" to limit overhead: that being said I'm by no means a expert of the codebase, wdyt?
@codedesperate commented on GitHub (Jul 25, 2022):
I would love to see such a feature!
@zwimer commented on GitHub (Jan 10, 2024):
Or, related, allow moving the torrent to a different download directory. For example, Radarr might download files to the
/downloads/Radarrdownload directory; but it would be nice if on upgrading a file it might move the old file to/downloads/Radarr-Recycledirectory.@zwimer commented on GitHub (Jan 10, 2024):
This would be super appreciated for organizational purposes; it'd make it easy to find 'no longer needed' torrents that we could safely prune when free space is required; without having to monitor each and every download notification to see if we have to manually relocate/relabel some now unnecessary torrent.
@bakerboy448 commented on GitHub (Jan 10, 2024):
and
As previously noted - qbitmanage handles this.
@zwimer commented on GitHub (Jan 10, 2024):
The hardlinks setting? I'm on a copy-on-write files system so I'm using copies (since COW makes those take negligible space) as that is more flexible as it allows cross-device copies (such as between docker mounts) and work with different linux users, etc.
Or is there some Radarr integration I am unaware of?
@bakerboy448 commented on GitHub (Jan 10, 2024):
Radarr and qbitmanage have nothing to do with each other.
Please use Discord for support/questions.
@zwimer commented on GitHub (Jan 10, 2024):
I looked into it then further asked on discord as suggested, it would seem that qbitmanage does this via hardlink detection. For people who do hardlink the program should work. Though for people who instead copy (which works well on COW filesystems), it wouldn't be a replacement for the feature being requested above.
@theelog commented on GitHub (Feb 20, 2024):
This feature would be a life-saver for everyone who's to scared to use Qbitmanage.
@zwimer commented on GitHub (Mar 27, 2024):
Or those who cannot use it / it would be inadequate for. For example, if you have your download client and other client as different users, hardlinks will not work since hardlink users must be the same. Copying works fine, and on a COW filesystem can even be more efficient than hardlinks.