mirror of
https://github.com/Radarr/Radarr.git
synced 2026-03-02 22:57:34 -05:00
Renaming does not rename companion .srt file #9205
Labels
No labels
Area: API
Area: Database
Area: Db-migration
Area: Download Clients
Area: Extras
Area: Import Lists
Area: Indexer
Area: Metadata API
Area: Notifications
Area: Organizer
Area: Parser
Area: Scanning
Area: Tooling
Area: UI
Area: Unit Tests
On Hold: MetadataAPI Blocking
On Hold: MetadataAPI Blocking
Priority: High
Priority: Low
Priority: Medium
Status: Accepted
Status: Cannot Reproduce
Status: Confirmed
Status: Help Wanted
Status: In Progress
Status: Indexer - need invite
Status: Info Needed
Status: Investigating
Status: Logs Needed
Status: Maybe One Day
Status: Needs Triage
Status: On Hold
Status: Ready for Review
Status: Unlikely
Status: Waiting for OP
Status: Won't Fix
Type: Bug
Type: Documentation
Type: Duplicate
Type: Enhancement
Type: External Bug
Type: Feature Request
Type: Regression
Type: Support
Type: Support.
conflict
lidarr-pull
no-conflict
not-pulled
readarr-pull
readarr-pull
sonarr upstream
sonarr-pull
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Radarr#9205
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @loongemperor on GitHub (Jun 17, 2025).
Is there an existing issue for this?
Current Behavior
Renaming does not rename companion .srt files.
for example:
when using the rename option becomes
only the webm file is renamed and the
.srtfile is ignored.tested on multiple different movies.
Expected Behavior
rename the .srt file alongside the webm
Steps To Reproduce
add a movie with a companion .srt file
rename it
Environment
What branch are you running?
Master
Trace Logs? Not Optional
https://hastebin.com/share/onupayimig.yaml
Trace Logs have been provided as applicable. Reports will be closed if the required logs are not provided.
trace- that are relevant and show this issue.@loongemperor commented on GitHub (Jun 17, 2025):
I had the idea that maybe it fails to recognize it because there is no language tag so I tried
and it had the same result of renaming the webm and ignoring the .srt file
@mynameisbogdan commented on GitHub (Jun 17, 2025):
Do you have custom chown user and permissions set? Because you have permissions issues in the logs and I can't reproduce.
@loongemperor commented on GitHub (Jun 18, 2025):
I am using the default user for the official truenas install. which is 568. which is the default "apps" user in truenas.
The dataset in question uses posix open permissions. owner is a different user called "share". but it gives group
Group – default – builtin_usersfull RWX permissions.The failed changing of permission happen after the rename successfully finishes. Is there perhaps an issue where it does something like
where if changing permissions on file 1 fails it aborts instead doing rename file 2?
I did try to bulk rename multiple series at once and they all successfully renamed the webm but failed to rename the srt in a single operation. but it might still be such an issue where failing to set permissions to 777 after a rename causes it to abort renaming companion files but not abort the whole process.
making it not abort after permission change failure would be the bugfix. and maybe report to the user that it failed to change permissions...
also I noticed something odd one line before the failed permission change
2025-06-16 23:55:45.0|Trace|ConfigService|Using default config value for 'chowngroup' defaultValue:''there is no such thing as
chowngroupthere ischownthat is used to change the group ownership of a file viachown [options] username:groupname file[s]@bakerboy448 commented on GitHub (Jun 18, 2025):
This has no relevance to any command and is referring to the radarr config value - the Chown Group.
There is just about never a reasonable usecase for having radarr changing the file permissions and any and all instances seen so far indicate poor setups of users download clients not setting the correct user/group/umask.
Furthermore, if you're having radarr change the permissions then the user radarr is running as must own the file as is clearly noted in the UI.
Given the improper configuration and inability to reproduce this appears to be a support issue not a bug.
If you still have issues after correcting your broken setup - For support and inquiries, please use our Discord channel. GitHub is designated solely for bug reports and feature requests. It seems that this issue may fall under a support request, so we kindly ask you to visit our Discord for assistance. Thank you.
@loongemperor commented on GitHub (Jun 18, 2025):
@bakerboy448 this does not seem to be a permission issue. I fixed the permissions and the problem persists with no permission errors.
https://hastebin.com/share/bahomeviwo.yaml
it still fails to rename the .srt files. this shows that the permissions issue was not relevant to this bug.
furthermore, even if this was a permissions issue, there are still addition bugs being exposed here. which are:
bug 1. radarr fails to notice that it failed to perform a chown. it thinks chown was successful when it failed (I tested and it did not change ownership). this later results in failing to perform
chmodbecause it does not own the filesbug 2. radarr fails to report to the user it is failing to perform chmod. this should appear as an error message under System > Status instead of only in the trace log
bug 3. if this really was a permission issue (I fixed the permissions and it still occurs so it clearly isn't. but if it was) then there would be the bug of aborting the rename of the .srt file if the .webm file failed to change its permissions. even though they are different unrelated files. however fixing the permissions issue did not fix the unrenamed .srt so this shouldn't be a permissions issue.
That said, you are right that there is no reason to use that feature of changing permissions automatically. so I disabled it.
I also tested a brand new install and it does not enable this setting by default. meaning I must have set it myself at some point.