mirror of
https://github.com/Radarr/Radarr.git
synced 2026-03-02 22:57:34 -05:00
Passthepopcorn Indexer Flags from Prowlarr #9234
Labels
No labels
Area: API
Area: Database
Area: Db-migration
Area: Download Clients
Area: Extras
Area: Import Lists
Area: Indexer
Area: Metadata API
Area: Notifications
Area: Organizer
Area: Parser
Area: Scanning
Area: Tooling
Area: UI
Area: Unit Tests
On Hold: MetadataAPI Blocking
On Hold: MetadataAPI Blocking
Priority: High
Priority: Low
Priority: Medium
Status: Accepted
Status: Cannot Reproduce
Status: Confirmed
Status: Help Wanted
Status: In Progress
Status: Indexer - need invite
Status: Info Needed
Status: Investigating
Status: Logs Needed
Status: Maybe One Day
Status: Needs Triage
Status: On Hold
Status: Ready for Review
Status: Unlikely
Status: Waiting for OP
Status: Won't Fix
Type: Bug
Type: Documentation
Type: Duplicate
Type: Enhancement
Type: External Bug
Type: Feature Request
Type: Regression
Type: Support
Type: Support.
conflict
lidarr-pull
no-conflict
not-pulled
readarr-pull
readarr-pull
sonarr upstream
sonarr-pull
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Radarr#9234
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @xombiemp on GitHub (Jul 23, 2025).
Is there an existing issue for this?
Is your feature request related to a problem? Please describe
The search results in Radarr do not display the PTP_Approved or PTP_Golden indexer flags when using the PTP indexer from Prowlarr.
Describe the solution you'd like
I've searched and found a number of issues related to this feature over the years, but it's not really clear to me what would need to happen to support the PTP_Approved and PTP_Golden flags. I'm not entirely sure if changes would need to happen in Prowlarr or Radarr or perhaps both.
I found this commit https://github.com/Prowlarr/Prowlarr/pull/64 which appears to add the ability to add per indexer flags. And as part of that commit it appears that there is something going on with Approved and Golden flags
github.com/Prowlarr/Prowlarr@fab74b58fa/src/NzbDrone.Core/Indexers/Definitions/PassThePopcorn/PassThePopcorn.cs (L69)I'm not positive, but I believe this is adding approved and golden torznab tags. I found this closed issue that seems to support that idea https://github.com/Radarr/Radarr/issues/7951
I also found this commit on the Radarr side https://github.com/Radarr/Radarr/pull/9145 that adds support for additional torznab flags. Perhaps there needs to be some additional logic here
github.com/Radarr/Radarr@8bef9b4da7/src/NzbDrone.Core/Indexers/Torznab/TorznabRssParser.cs (L256)Something like this?
So what is missing? What needs to be done in which product to make this work?
Describe alternatives you've considered
Without Prowlarr, using the builtin Passthepopcorn indexer, the PTP_Approved and PTP_Golden flags work fine. But I'd like to use Prowlarr.
Anything else?
Is Prowlarr already sending the required info? Are changes required in Prowlarr? If so, what are they?
Are changes required in Radarr? Does Radarr need to look for torznab tags sent from Prowlarr? Or what are the changes required in Radarr?
@xombiemp commented on GitHub (Jul 23, 2025):
I was able to confirm with tcpdump that Prowlarr is sending the torznab tags golden and approved:
This leads me to believe the there are no required changes in Prowlarr, and that Radarr needs to be updated to look for these tags and apply the indexer Flags as in the code sample above. Does this sound right?
@bakerboy448 commented on GitHub (Jul 23, 2025):
https://github.com/Radarr/Radarr/issues/6533#issuecomment-2378216083
@xombiemp commented on GitHub (Jul 23, 2025):
@bakerboy448 I'm a little confused by the quoted comment. The context is a bit different than this request. It's not completely clear to me if @mynameisbogdan was referring to work in Prowlarr or Radarr that would not be supported.
This is definitely a desired feature by many people, according to searches of past issues/Reddit etc, and I'm not sure what the reservation is on implementing it. The flags PTP_Approved/PTP_Golden are non-standard, but Radarr is the thing that introduced them, right? Prowlarr is already sending the data as torznab tags, so it seems logical that the next step would be for Radarr to parse those and utilize them to assign the Indexer flags that it created in the first place.
Let me know if I'm missing something fundamental here.
@bakerboy448 commented on GitHub (Jul 23, 2025):
@xombiemp commented on GitHub (Jul 23, 2025):
Ok, here is another quote:
https://github.com/Radarr/Radarr/pull/9145#issuecomment-1784073736
Not sure what I did to annoy you. This has been discussed as a potential enchantment for a while now. I tried to be thorough and do some research for this issue and I'm met with a thumbs down. Why so hostile?
It appears that most of the work is already done to support this and it just needs to be hooked up on the Radarr side. I still don't understand the non-standard reasoning. Radarr is the thing that created the PTP_Golden/PTP_Approved flags, so why can't Radarr look for these from torznab? Prowlarr is already sending them.
@mynameisbogdan commented on GitHub (Jul 23, 2025):
Like I explained already, they need to be renamed to something to more generic in order to be able to use them for other sites as well.
Implementing them in current form would only prove a PITA in the future when support for other sites is wanted.
@xombiemp commented on GitHub (Jul 23, 2025):
Thanks for the reply. That makes sense. This is really what I wanted to understand. When you say they need to be renamed, we are talking about the flags in Radarr, correct?
Is Prowlarr good to go as is?