mirror of
https://github.com/SuiteCRM/SuiteCRM.git
synced 2026-03-02 19:16:58 -05:00
Not all imported targets are added to target list for large imports #1915
Labels
No labels
Area: API
Area: Campaigns
Area: Cases
Area: Clean Up
Area: Clean Up: Performance
Area: Dashlets
Area: Databases
Area: Developer Tools
Area: Elasticsearch
Area: Elasticsearch
Area: Emails
Area: Emails:Campaigns
Area: Emails:Cases
Area: Emails:Compose
Area: Emails:Config
Area: Emails:Templates
Area: Environment
Area: Installation
Area: Language
Area: Mobile
Area: Module
Area: PDFs
Area: PHP8
Area: Reports
Area: Studio
Area: Styling
Area: Upgrading
Area: Workflow
Area:Activity Stream
Area:Calls
Area:Import
Area:Projects
Area:Search
Area:Surveys
Area:Themes
Area:Users
Branch:Hotfix
Good First Issue
Hacktoberfest
Help Wanted
PR:Community Contribution
PR:Type:Enhancement
Priority:Critical
Priority:Important
Priority:Moderate
Severity: Major
Severity: Minor
Severity: Moderate
Status: Requires Code Review
Status: Requires Updates
Status: Stale
Status: Team Investigating
Status:Assessed
Status:Fix Proposed
Status:Needs Assessed
Status:Requires Automated Tests
Type: Bug
Type:Deprecated
Type:Discussion
Type:Duplicate
Type:Invalid
Type:Question
Type:Suggestion
Type:Suggestion
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/SuiteCRM-SuiteCRM#1915
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @gitnito on GitHub (May 10, 2017).
Issue
After successfully importing a large number of targets, when you click to "Add to target list", and create a new target list and then select it, only a portion of the imported targets get added to the list. In our last case we imported 7668 targets, but only 2479 got added to the target list. Fortunately we had a way to distinguish the imported targets from previously existing targets, and were able to select them and add them under the targets page. This is a critical bug, since if the targets you imported do not have a lot of unique data it can be difficult or impossible to later separate them to add to target list; and in essence leaving you with thousands of target records on your database that you can not use. They can still be identified directly on the database with the following SQL command:
SELECT * FROM prospects WHERE id NOT IN (SELECT related_id FROM prospect_lists_prospects)
Expected Behavior
All imported targets should be added to the target list.
Actual Behavior
Only a portion of the targets where added to the target list (2479 out of 7668 in our case)
Possible Fix
Maybe there is a limit somewhere. This has happened 2 times to us. The first time we did not realize it until we went to do a campaign and noticed the discrepancy.
Steps to Reproduce
Context
Importing targets for campaign. In our opinion this is high priority, since it could leave you with thousands of target records in your database not associated with any list; but more importantly, if you are not specifically looking at it, it is very likely you will not notice this issue until days later or after you have performed other imports, further complicating things
Your Environment
@pgorod commented on GitHub (May 10, 2017):
Do you see anything in your logs at the time when it's adding to the target list? Maybe it's just the operation that is too long and your PHP configurations block it, or it runs out of memory.
Anyway, it should work, of course, or an error should be shown to the user... but it would be useful to know what you find in
suitecrm.logandphp_errors.log.@hemanthvaddi commented on GitHub (Aug 24, 2017):
I have the same issue. Is it solved?
@pgorod commented on GitHub (Aug 24, 2017):
@hemanthvaddi no, the original poster didn't answer the questions, so this didn't go anywhere. If you have the same problem, and you can answer my questions above, that would be helpful. Also, please tell us your versions of OS, database, web server, PHP and SuiteCRM. Thanks.
@hemanthvaddi commented on GitHub (Aug 24, 2017):
OS: Ubuntu 14.04.4
Database: MySQL 14.14
Webserver: Apache 2.4.7
PHP: 5.5.9
SuiteCRM 7.6.4
@hemanthvaddi commented on GitHub (Aug 24, 2017):
The problem only occurs when I select the list of Targets as a Non-Admin User. As an admin user, it gets all the targets into the TargetList.
The log seems to truncate in the middle of the process. So I'm unable to tail it for longer lists of targets.
@pgorod commented on GitHub (Aug 24, 2017):
Your MySQL version number must be wrong, it should be something like 5.5 or 5.7. But never mind, I don't think that is relevant.
SuiteCRM 7.6.4 is 27 versions ago, there were a LOT of bug fixes meanwhile... I don't know if this could be already fixed.
When tailing logs sometimes the log rotates (gets copied to
suitecrm1.log) and the tail goes silent. But if you restart the tail, it keeps going.Or it could be having a PHP Fatal error that does not get logged in
suitecrm.log, but you should see it inphp_errors.log.Without an error message, and on an older system, it's hard to help...
@hemanthvaddi commented on GitHub (Aug 28, 2017):
I have also checked it in the newer version of SuiteCRM (7.8.3). The issue still seems to persist. I am unable to pursue the source of the issue and why it is affecting only Non-Admin users. In my case when we try to import more than 10000 Targets into a Target List, it only adds 8000-9000 targets.
May I ask if it is possible for you to test this issue from your side as a non-admin user?
@pgorod commented on GitHub (Aug 28, 2017):
Hi. You can do tests yourself on these two online demos:
demo.suiteondemand.com (only allows regular user access)
www.softaculous.com/demos/SuiteCRM (allows admin access)
You haven't checked your logs yet? You could have a simple error message there telling you directly what the problem is.
@hemanthvaddi commented on GitHub (Aug 29, 2017):
I couldn't test it on demo.suiteondemand because when I try importing a large list of targets, the session is expiring. And this issue isn't there for the admin user, I think there is no point in testing it in softaculous.
@pgorod commented on GitHub (Aug 29, 2017):
In
php.ini, what do you have as memory_limit and max_execution_time? Does increasing those values solve the problem with the large import?@Dillon-Brown commented on GitHub (Oct 9, 2017):
Closing due to inactivity / inability to replicate. Please reopen if you are able to replicate this as a core issue and provide clear steps. Thanks.
@rahulner commented on GitHub (Apr 12, 2018):
I was not able to add targets the target list, Search was only adding current page of 20. So i did add via phpmyadmin using below sql , may be useful to someone
insert into prospect_lists_prospects SELECT UUID() id, pl.id prospect_list_id,p.id related_id, 'Prospects' related_type, now() date_modified , 0 deleted FROM prospects p, prospect_lists pl where p.description not like '%your search criteria for targets%' and p.department='another search criteria for target..' and p.deleted = 0 and pl.name = 'Name of the target list' and not EXISTS ( select 1 from prospect_lists_prospects plp where plp.prospect_list_id= pl.id and plp.related_id = p.id )@lucas7793 commented on GitHub (May 28, 2018):
I'm experiencing the same problem in the current version 7.10.5. I created a report with 4579 results. Then I click on
Add to Prospect List. After it has finished there are only 3136 entries in the selected prospect list. But it's not that the list is cut of somewhere, there are missing entries in between. After trying to add the prospects again to the same list, the amount does not change. From the logs I can not see any errors.For me it also does not change if it's a admin or non-admin user.
@pgorod commented on GitHub (May 28, 2018):
@lucas7793 that is a good issue to raise in the forums, not here. I will help you out there.
You need to look at your logs and report any errors there at the time of the failed import.
@dtosun61 commented on GitHub (Aug 15, 2018):
I'm experiencing the same problem in the my version 7.8.18. Any solution for this?