mirror of
https://github.com/SuiteCRM/SuiteCRM.git
synced 2026-03-02 19:16:58 -05:00
Reports not editable by regular users based on "Line Items" Report Module #2453
Labels
No labels
Area: API
Area: Campaigns
Area: Cases
Area: Clean Up
Area: Clean Up: Performance
Area: Dashlets
Area: Databases
Area: Developer Tools
Area: Elasticsearch
Area: Elasticsearch
Area: Emails
Area: Emails:Campaigns
Area: Emails:Cases
Area: Emails:Compose
Area: Emails:Config
Area: Emails:Templates
Area: Environment
Area: Installation
Area: Language
Area: Mobile
Area: Module
Area: PDFs
Area: PHP8
Area: Reports
Area: Studio
Area: Styling
Area: Upgrading
Area: Workflow
Area:Activity Stream
Area:Calls
Area:Import
Area:Projects
Area:Search
Area:Surveys
Area:Themes
Area:Users
Branch:Hotfix
Good First Issue
Hacktoberfest
Help Wanted
PR:Community Contribution
PR:Type:Enhancement
Priority:Critical
Priority:Important
Priority:Moderate
Severity: Major
Severity: Minor
Severity: Moderate
Status: Requires Code Review
Status: Requires Updates
Status: Stale
Status: Team Investigating
Status:Assessed
Status:Fix Proposed
Status:Needs Assessed
Status:Requires Automated Tests
Type: Bug
Type:Deprecated
Type:Discussion
Type:Duplicate
Type:Invalid
Type:Question
Type:Suggestion
Type:Suggestion
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/SuiteCRM-SuiteCRM#2453
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @artjomsmorscakovs on GitHub (Nov 6, 2017).
Issue
Two users: Admin, Regular User
No Roles or Security Groups created
Case #1 Admin creates Report with Report Module equal to "Line Items"
Case #2 Regular User created Report with Report Module equal to "Line Items"
Expected Behavior
Both cases can create and view and edit
Actual Behavior
Case #1 Report created and viewable by Admin, Regular User not able to view it (It sees the record but link doesn`t show, If you try to go to a detailed view using url and Id, then you get error:
"You do not have access to this area. Contact your site administrator to obtain access.
Redirect to Home in 3 seconds
Case #2 After pushing save button you get message "You do not have access to this area. Contact your site administrator to obtain access.
Redirect to Home in 3 seconds
Possible Fix
I was able to fix this by creating records for "Line Items" module in acl_actions table
INSERT INTO
acl_actions(id,date_entered,date_modified,modified_user_id,created_by,name,category,acltype,aclaccess,deleted) VALUES ('3b51b254-5b6c-b2db-abc2-582e8ac2f265', '2016-11-18 05:00:25', '2016-11-18 05:00:25', '1', '', 'access', 'AOS_Products_Quotes', 'module', '89', '0'), ('3d6a812a-41b2-c9a5-abc7-582e8a5c8f34', '2016-11-18 05:00:25', '2016-11-18 05:00:25', '1', '', 'delete', 'AOS_Products_Quotes', 'module', '90', '0'), ('3ce4825f-da3e-d3d7-abcf-582e8a4057a6', '2016-11-18 05:00:25', '2016-11-18 05:00:25', '1', '', 'edit', 'AOS_Products_Quotes', 'module', '90', '0'), ('3e76e190-8ca9-f4fe-abc6-582e8ac8c2ec', '2016-11-18 05:00:25', '2016-11-18 05:00:25', '1', '', 'export', 'AOS_Products_Quotes', 'module', '90', '0'), ('3dedb06c-23f1-a963-abc3-582e8a48db52', '2016-11-18 05:00:25', '2016-11-18 05:00:25', '1', '', 'import', 'AOS_Products_Quotes', 'module', '90', '0'), ('3c648899-74c9-673a-abc3-582e8af5b317', '2016-11-18 05:00:25', '2016-11-18 05:00:25', '1', '', 'list', 'AOS_Products_Quotes', 'module', '90', '0'), ('3f002d14-060b-28f0-6bd5-abce8ab1ec1f', '2016-11-18 05:00:25', '2016-11-18 05:00:25', '1', '', 'massupdate', 'AOS_Products_Quotes', 'module', '90', '0'), ('3be1b70f-2f88-a396-030d-abce8a2de8b7', '2016-11-18 05:00:25', '2016-11-18 05:00:25', '1', '', 'view', 'AOS_Products_Quotes', 'module', '90', '0');Steps to Reproduce
Context
Reports not visible for Reqular Users
Your Environment
@iteschke commented on GitHub (Dec 29, 2017):
I have a problem in reporting module which is very similar:
Issue
Regular user cannot create a report with a condition which bases on a line item which is linked from another module. Corresponding reports which were created by an admin cannot be executed by a regular user.
Expected Behavior
Regular user can select fields from line items as a condition.
Actual Behavior
The field of line items will not appear for selection when defining a condition.
Steps to Reproduce
Environment
Thanks,
Ingo
@PedroErnst commented on GitHub (Feb 7, 2018):
Thanks @artjomsmorscakovs and @iteschke
I've been looking into this and I think the underlying problem is that there is no permissions for line items per se, in this case the system should look at the permission for Quotes for the user, and if the user has access to Quotes he should be able to see Line Items Reports.