mirror of
https://github.com/SuiteCRM/SuiteCRM.git
synced 2026-03-02 19:16:58 -05:00
Some files still use the DB global variable. #3705
Labels
No labels
Area: API
Area: Campaigns
Area: Cases
Area: Clean Up
Area: Clean Up: Performance
Area: Dashlets
Area: Databases
Area: Developer Tools
Area: Elasticsearch
Area: Elasticsearch
Area: Emails
Area: Emails:Campaigns
Area: Emails:Cases
Area: Emails:Compose
Area: Emails:Config
Area: Emails:Templates
Area: Environment
Area: Installation
Area: Language
Area: Mobile
Area: Module
Area: PDFs
Area: PHP8
Area: Reports
Area: Studio
Area: Styling
Area: Upgrading
Area: Workflow
Area:Activity Stream
Area:Calls
Area:Import
Area:Projects
Area:Search
Area:Surveys
Area:Themes
Area:Users
Branch:Hotfix
Good First Issue
Hacktoberfest
Help Wanted
PR:Community Contribution
PR:Type:Enhancement
Priority:Critical
Priority:Important
Priority:Moderate
Severity: Major
Severity: Minor
Severity: Moderate
Status: Requires Code Review
Status: Requires Updates
Status: Stale
Status: Team Investigating
Status:Assessed
Status:Fix Proposed
Status:Needs Assessed
Status:Requires Automated Tests
Type: Bug
Type:Deprecated
Type:Discussion
Type:Duplicate
Type:Invalid
Type:Question
Type:Suggestion
Type:Suggestion
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/SuiteCRM-SuiteCRM#3705
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @connorshea on GitHub (Apr 30, 2019).
Most of the
$dbglobals were removed in this commit (see also this PR), but a decent number still exist.Files with a
$dbglobal:modules/UserPreferences/UserPreference.phpmodules/Administration/updater_utils.phpmodules/MailMerge/Step1.phpmodules/Reminders/Reminder.phpinstall/suite_install/AdvancedOpenSales.phpmodules/Charts/Dashlets/PipelineBySalesStageDashlet/PipelineBySalesStageDashlet.phpmodules/Emails/EmailUI.php(#7262)include/social/twitter/twitterapi.phpmodules/SecurityGroups/MassAssign.phptests/api/_bootstrap.phpmodules/Charts/Dashlets/OpportunitiesByLeadSourceDashlet/OpportunitiesByLeadSourceDashlet.php(#7262)modules/Leads/views/view.convertlead.php(#7262)modules/Project/controller.php(#7262)include/Dashlets/DashletGenericChart.phptests/unit/_bootstrap.phpmodules/AM_ProjectTemplates/controller.phpmodules/AM_ProjectTemplates/controller.php(same file, different line)include/MassUpdate.phpmodules/OAuth2Tokens/OAuth2Tokens.phpinclude/Localization/Localization.phpinclude/SubPanel/SubPanelRowCounter.phpmodules/Administration/UpgradeWizard_commit.phptests/bootstrap.phpmodules/Project/chart.php(#7262)modules/Project/Project.php(#7262)Should these all be replaced by
DBManagerFactory::getInstance()like the other commit?I got all these by searching for
db globalin GitHub@connorshea commented on GitHub (Jun 4, 2019):
This isn't really resolved :)