Contract Reminder Call get wrong parent_id #3831

Open
opened 2026-02-20 16:10:23 -05:00 by deekerman · 0 comments
Owner

Originally created by @gody01 on GitHub (Jul 11, 2019).

Reminder Call generated when creating Contract gets wrong parent_id. On create/save parent_id is AccountID, on Edit/save parent_id is ContractID

Issue

Reminder Call is generated, when we create Contract.
On first save, generated Call gets AccountID as its parent_id.
On subsequent edit of Contract and save parent_id is changed to ContractId (which is supposedly more corrrect, as otherwise in Call we don't have reference of contract to whom reminder calls belongs.

Expected Behavior

Generated Call should have ContractId as it's parent_id already on creation.

Actual Behavior

Coresponding Call gets AccountID as parent_id on creation.

Possible Fix

Relocate $this->createReminder(); function below
$return_id = parent::save($check_notify);

Steps to Reproduce

  • Create Contract

  • Enter Reminder Date

  • Check generated Call -> Related Object is Account of Contract

  • Edit Contract

  • Save

  • Check generated Call -> Related Object is Contract itself.

Context

  • Renewal Reminder Calls are important for tracking Contracts expiration.
  • Cheduled Reminder Calls should be connected to Actual Contract, since we can have many contracts with same Account, and if we dont have relations Call -> Contract we can't know for which particular Contract Reminder is for.

I think this should be High priority

Your Environment

  • SuiteCRM Version used: 7.11.6
  • Browser name and version (e.g. Chrome Version 51.0.2704.63 (64-bit)): All
  • Environment name and version (e.g. MySQL, PHP 7): mariadb 5.6, PHP 7.2
  • Operating System and version (e.g Ubuntu 16.04): CentOS 7
Originally created by @gody01 on GitHub (Jul 11, 2019). <!--- Provide a general summary of the issue in the **Title** above --> Reminder Call generated when creating Contract gets wrong parent_id. On create/save parent_id is AccountID, on Edit/save parent_id is ContractID #### Issue Reminder Call is generated, when we create Contract. On first save, generated Call gets AccountID as its parent_id. On subsequent edit of Contract and save parent_id is changed to ContractId (which is supposedly more corrrect, as otherwise in Call we don't have reference of contract to whom reminder calls belongs. #### Expected Behavior Generated Call should have ContractId as it's parent_id already on creation. #### Actual Behavior Coresponding Call gets AccountID as parent_id on creation. #### Possible Fix Relocate $this->createReminder(); function below $return_id = parent::save($check_notify); #### Steps to Reproduce - Create Contract - Enter Reminder Date - Check generated Call -> Related Object is Account of Contract - Edit Contract - Save - Check generated Call -> Related Object is Contract itself. #### Context - Renewal Reminder Calls are important for tracking Contracts expiration. - Cheduled Reminder Calls should be connected to Actual Contract, since we can have many contracts with same Account, and if we dont have relations Call -> Contract we can't know for which particular Contract Reminder is for. I think this should be High priority #### Your Environment * SuiteCRM Version used: 7.11.6 * Browser name and version (e.g. Chrome Version 51.0.2704.63 (64-bit)): All * Environment name and version (e.g. MySQL, PHP 7): mariadb 5.6, PHP 7.2 * Operating System and version (e.g Ubuntu 16.04): CentOS 7
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/SuiteCRM-SuiteCRM#3831
No description provided.