mirror of
https://github.com/SuiteCRM/SuiteCRM.git
synced 2026-03-02 19:16:58 -05:00
Insideview banner advertisement popping out #4313
Labels
No labels
Area: API
Area: Campaigns
Area: Cases
Area: Clean Up
Area: Clean Up: Performance
Area: Dashlets
Area: Databases
Area: Developer Tools
Area: Elasticsearch
Area: Elasticsearch
Area: Emails
Area: Emails:Campaigns
Area: Emails:Cases
Area: Emails:Compose
Area: Emails:Config
Area: Emails:Templates
Area: Environment
Area: Installation
Area: Language
Area: Mobile
Area: Module
Area: PDFs
Area: PHP8
Area: Reports
Area: Studio
Area: Styling
Area: Upgrading
Area: Workflow
Area:Activity Stream
Area:Calls
Area:Import
Area:Projects
Area:Search
Area:Surveys
Area:Themes
Area:Users
Branch:Hotfix
Good First Issue
Hacktoberfest
Help Wanted
PR:Community Contribution
PR:Type:Enhancement
Priority:Critical
Priority:Important
Priority:Moderate
Severity: Major
Severity: Minor
Severity: Moderate
Status: Requires Code Review
Status: Requires Updates
Status: Stale
Status: Team Investigating
Status:Assessed
Status:Fix Proposed
Status:Needs Assessed
Status:Requires Automated Tests
Type: Bug
Type:Deprecated
Type:Discussion
Type:Duplicate
Type:Invalid
Type:Question
Type:Suggestion
Type:Suggestion
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/SuiteCRM-SuiteCRM#4313
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @francescor on GitHub (Jun 5, 2020).
We just notices an advertisement while surfing our private hosted SuiteCRM installation.
The advert promote: http://www.insideview.com where at the terms of use at http://www.insideview.com/cat-terms-use.html I read something very serious (and bad):
"You hereby grant InsideView a non-exclusive, royalty-free, worldwide license to use the Customer Data as may be reasonable or necessary for InsideView to provide the Services to You."
The advert is at center of a page while viewing a customer (our customer!) data, and the banner says: if click you agree (!!)
we are willing to send you the screenshot if you want.
SuiteCRM Version 7.11.13, with data imported from Sugar Version 6.5.25 (Build 344), on brand new linux Centos 7, php 7.4
@francescor commented on GitHub (Jun 5, 2020):
This is the HTML code that produce the banner
please note that, even the cited privacy banner lead to a non existing page!
@pgorod commented on GitHub (Jun 5, 2020):
This just means that your server got hacked, or your browser has a bad add-on installed... not a SuiteCRM issue.
@pgorod commented on GitHub (Jun 5, 2020):
I see they have a SugarCRM plugin called InsideView, maybe it works also with SuiteCRM and you installed it? Check your Admin / Module Loader page.
@francescor commented on GitHub (Jun 5, 2020):
Here the screenshot

@francescor commented on GitHub (Jun 5, 2020):
I can probably disable the whole "InsideView" advert in here?
can I ?
@pgorod commented on GitHub (Jun 5, 2020):
That seems to be a legitimate software, that somebody installed on your server. You should determine what it does, before removing it. You probably paid for it.
You can also contact the makers of that software and ask them about the annoying ad. I assume they thought it was a good idea to get that permission, for GDPR reasons (or similar).
@pgorod commented on GitHub (Jun 5, 2020):
Please close this Issue here, it's really not a SuiteCRM problem.
We can keep discussing this in comments even after the Issue is closed, if you need more help. Thanks
@francescor commented on GitHub (Jun 5, 2020):
Yes, my client had a previous installation of SugarCRM (Indeed I read "Sugar Version 6.5.25 Build 344" in the actual SuiteCRM installation about page): I'm very glad this stuff does not come from your code, believe me!
@francescor commented on GitHub (Jun 5, 2020):
Is this about this same issue? https://community.suitecrm.com/t/inside-view-subpanel-how-to-remove/12966
@pgorod many thanks for your feeds: please have a look, since your statement about the server being hacked forced us to open a serious internal incident.
It seems to me that this "advertisement" was part of the previous sugarcrm, which has nothing to do with SuiteCRM (I'm glad!) but unfortunately that king of code got automatically imported in our brand new SuiteCRM installation that we just set up migrating from sugar following SuiteCRM migration instructions.
This is sure something that can help previous (new) users coming here from SugarCRM, and will keep SuiteCRM clean
@pgorod commented on GitHub (Jun 5, 2020):
Did you check Admin / Module Loader page to see if the module can be uninstalled from there?
You're better off ensuring that no part of that add-on is still operational, I don't know if the Connector is everything, or if there is more.
I agree this information might be useful for the future, though not here, it should be on the Forums, it's better to look for help there before coming here.
@francescor commented on GitHub (Jun 5, 2020):
Yes, sorry for not telling you: Admin / Module Loader page has nothing on it
@francescor commented on GitHub (Jun 5, 2020):
Ok, yes, next time I'll start with the forum, thanks
here is where that code should just be:
@francescor commented on GitHub (Jun 5, 2020):
and apparently this is the original writer of that code https://php.wekeepcoding.com/article/12052779/sugarcrm+community+edition+set+connectors+properties+showing+blank+box
@chris001 commented on GitHub (Jun 5, 2020):
Don't panic. InsideView is a third party add on service for filling in business data on your leads, it was promoted inside the SugarCRM 6.5 Community Edition (the open source version). You can disable it without any worries. https://www.insideview.com/how-we-source-personal-data/
@francescor commented on GitHub (Jun 6, 2020):
wait a sec: I just downloaded and installed a pristine SuiteCRM 7.11.13, and that connector is there
and yes, it is just not enable by default
Ok, so I just need to disable, which solve my problem, thanks.
BUT, let me say that that connector smells pretty bad: there "Terms of Use" is pretty bad I think, and even in this brand new installation of SuiteCRM the link to their privacy policy is wrong (https://www.insideview.com/cat-privacy.html/ ).
I do not know the SuiteCRM community, yet, and how you developers work, but I wonder if developers are aware of this.
@chris001 commented on GitHub (Jun 6, 2020):
You could remove it by deleting the connector code and its directories. It comes with the SugarCRM 6.5 CE, so you would have to delete it every time you upgraded the core SugarCRM 6.5 CE software.
@Mac-Rae commented on GitHub (Jun 8, 2020):
Not sure how much we can do cause it's from before the fork, I'll mark this up as a potential cleanup for now.
@francescor although already said please consult the fourms and raise issues likes these there in the future. At worse if we feel it is a bug we'll direct you to raise and issue here anyways 👍👍
@Mac-Rae commented on GitHub (Jun 8, 2020):
@francescor could you also please modify the title to better reflect the raised issue. Maybe something along the lines of "SugarCM Core Plugin does not link to privacy policy"
I'll point out we will take a look at editing the code or if deemed able and sensable potential removing this module however there's a lot resting on that for it being part of the legacy system that changing stuff can open doors you don't want to 👍
@francescor commented on GitHub (Jun 8, 2020):
@chris001 the code is in SuiteCrm, too
https://github.com/salesagility/SuiteCRM/tree/master/modules/Connectors/connectors/sources/ext/rest/insideview
and it is installed by default https://github.com/salesagility/SuiteCRM/blob/master/modules/Connectors/InstallDefaultConnectors.php
then even in the upgrade wizard https://github.com/salesagility/SuiteCRM/blob/master/modules/UpgradeWizard/uw_utils.php
and here, too https://github.com/salesagility/SuiteCRM/blob/master/install/install_utils.php
With that banner (I would have not another way of defining it) a user (any user in the organization) is only one click away from accepting the T&C which are pretty bad in my opinion (you can read it yourself, I can give my personal consideration about it) https://www.insideview.com/terms-use/ and, I have no time to dig it but for sure somebody is more prepared than me on this, it does not even respect the european privacy GDPR.
I am pretty surprised Insideview has such a priviege inside SuiteCRM code development: you may know the reason (which could be more than, legit, of course) and I would like to know it
@chris001 commented on GitHub (Jun 8, 2020):
InsideView was added to SugarCRM in April 2011, this was several years before data and privacy became huge issues and GDPR was adopted in May 2018. InsideView is a SugarCRM partner, so they agree not to misuse user data. They have a database with detailed data on almost all companies, like Dun & Bradstreet, so if you have the email address for a contact/lead/account stored in your SuiteCRM, and that email domain matches a company in the InsideView database, the software auto fills in the missing data about that person/company in the record for you, it saves a lot of user/employee time on re-typing in so much publicly known company data (address, phone numbers, fax numbers, website, industry code, company size, who the person reports to, etc). That being said, you may very well want to just disable the InsideView connector so that your users won't see the panel with their "terms of use" link, which is currently a broken link anyway, and possibly click on "Agree".
@francescor commented on GitHub (Jun 8, 2020):
Ok, I've got it now (and yes, I already removed its code in my client's server).
Where can I purpose developers the removal of that code? as you said:
@francescor commented on GitHub (Jun 8, 2020):
(btw @chris001 I see your website has a weird return a weird file in homepage, with somehow encoded
mv etc/ /old_etccommand inside)@chris001 commented on GitHub (Jun 8, 2020):
You should ask here in this issue for someone to submit a pull request, to modify the install settings for SuiteCRM included connectors, so that the InsideView connector would be installed as
disabled.Thank you - link fixed now.
@francescor commented on GitHub (Jun 8, 2020):
Ok, so I would suggest developers to submit a pull request to remove of the default enabled installation of the Insideview connector cited in code at
thanks
@Mac-Rae commented on GitHub (Jun 11, 2020):
Already been sorted @francescor when I marked it with a priority, your welcome to make the PR yourself if you know of the required changes and have the time 👍
@francescor commented on GitHub (Mar 3, 2021):
I see insideview is still enabled by default in a pristine installation, this is still a security issue to me
Can someone help me to find out what, in the installation setup, set
'enabled' => truein custom_directory/modules/Connectors/metadata/connectors.php@francescor commented on GitHub (Mar 3, 2021):
thanks to User: pgr, see https://community.suitecrm.com/t/insideview-a-connector-that-to-me-is-a-security-issue/78671/3, I just fired a pull request https://github.com/salesagility/SuiteCRM/pull/9052