mirror of
https://github.com/SuiteCRM/SuiteCRM.git
synced 2026-03-02 19:16:58 -05:00
Synchronising with iCal calendar declares that we are running a Sugar CRM instance (Not a SuiteCRM instance) #4358
Labels
No labels
Area: API
Area: Campaigns
Area: Cases
Area: Clean Up
Area: Clean Up: Performance
Area: Dashlets
Area: Databases
Area: Developer Tools
Area: Elasticsearch
Area: Elasticsearch
Area: Emails
Area: Emails:Campaigns
Area: Emails:Cases
Area: Emails:Compose
Area: Emails:Config
Area: Emails:Templates
Area: Environment
Area: Installation
Area: Language
Area: Mobile
Area: Module
Area: PDFs
Area: PHP8
Area: Reports
Area: Studio
Area: Styling
Area: Upgrading
Area: Workflow
Area:Activity Stream
Area:Calls
Area:Import
Area:Projects
Area:Search
Area:Surveys
Area:Themes
Area:Users
Branch:Hotfix
Good First Issue
Hacktoberfest
Help Wanted
PR:Community Contribution
PR:Type:Enhancement
Priority:Critical
Priority:Important
Priority:Moderate
Severity: Major
Severity: Minor
Severity: Moderate
Status: Requires Code Review
Status: Requires Updates
Status: Stale
Status: Team Investigating
Status:Assessed
Status:Fix Proposed
Status:Needs Assessed
Status:Requires Automated Tests
Type: Bug
Type:Deprecated
Type:Discussion
Type:Duplicate
Type:Invalid
Type:Question
Type:Suggestion
Type:Suggestion
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/SuiteCRM-SuiteCRM#4358
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @anothermouse on GitHub (Jul 31, 2020).
Issue
Connecting to the SuiteCRM iCal integration URL as given in profile->advanced settings tab declares the calendar as a SugarCRM instance:
modules/iCals/iCal.php:514:
$ical_array[] = array("X-WR-CALNAME", "$cal_name (SugarCRM)");
$ical_array[] = array("PRODID", "-//SugarCRM//SugarCRM Calendar//EN");
Expected Behavior
If anyone is serious about branding, shouldn't this be:
$ical_array[] = array("X-WR-CALNAME", "$cal_name (SuiteCRM)"); instead?
...and change the following line to be:
$ical_array[] = array("PRODID", "-//SuiteCRM//SuiteCRM Calendar//EN");
Actual Behavior
Possible Fix
Legacy code - just change the identity to SuiteCRM
Steps to Reproduce
Context
Low priority/simple fix from a usability point of view. Critical and unforgivable capital punishment issue from a branding perspective ;)
Your Environment
7.10.27, and 7.11.15 in same file but slightly different lines