mirror of
https://github.com/SuiteCRM/SuiteCRM.git
synced 2026-03-02 19:16:58 -05:00
Favorites adds record twice to the sidebar and to the db #4513
Labels
No labels
Area: API
Area: Campaigns
Area: Cases
Area: Clean Up
Area: Clean Up: Performance
Area: Dashlets
Area: Databases
Area: Developer Tools
Area: Elasticsearch
Area: Elasticsearch
Area: Emails
Area: Emails:Campaigns
Area: Emails:Cases
Area: Emails:Compose
Area: Emails:Config
Area: Emails:Templates
Area: Environment
Area: Installation
Area: Language
Area: Mobile
Area: Module
Area: PDFs
Area: PHP8
Area: Reports
Area: Studio
Area: Styling
Area: Upgrading
Area: Workflow
Area:Activity Stream
Area:Calls
Area:Import
Area:Projects
Area:Search
Area:Surveys
Area:Themes
Area:Users
Branch:Hotfix
Good First Issue
Hacktoberfest
Help Wanted
PR:Community Contribution
PR:Type:Enhancement
Priority:Critical
Priority:Important
Priority:Moderate
Severity: Major
Severity: Minor
Severity: Moderate
Status: Requires Code Review
Status: Requires Updates
Status: Stale
Status: Team Investigating
Status:Assessed
Status:Fix Proposed
Status:Needs Assessed
Status:Requires Automated Tests
Type: Bug
Type:Deprecated
Type:Discussion
Type:Duplicate
Type:Invalid
Type:Question
Type:Suggestion
Type:Suggestion
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/SuiteCRM-SuiteCRM#4513
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @joshscorpion on GitHub (Apr 1, 2021).
Hi,
I am using SuiteCRM 7.11.18 and php 7.2, on Apache and Ubuntu.
The issue I have is that when I open an Account/Contact/etc and select it as a Favorite (by clicking the star next to the name) and I refresh the page, 2 Favorites (of the same link) are added to the sidebar.
When I go directly to the database, I see that indeed added 2 instances of the same Favorite, instead of only once as it should.
I've been looking through all the cases in this github, didn't find anyone else that reported the same issue.
Any ideas?
I am not a developer, any help is really appreciated.
Many thanks
Josh
@SuiteBot commented on GitHub (Jun 13, 2022):
This issue has been mentioned on SuiteCRM. There might be relevant details there:
https://community.suitecrm.com/t/duplicate-links-for-favorited-contacts/81919/6
@pgorod commented on GitHub (Jun 13, 2022):
This issue is related to JS events firing twice and it affects other things. Sometimes it only appears after loading a record through the Ajax mechanism (for example, entering a detail view form the Recently Viewed list on the sidebar).
I can see the Favorites creation requests doubled in the Network tab of the browser; and I can also see duplicate requests for inline editing when I double-click on a field.
My own code is also having trouble with this: JS code injected in AfterUI hook executes twice. So when I add an action button on top, sometimes I get two buttons...
There are probably other manifestations of this same bug which we're not seeing yet...
@pgorod commented on GitHub (Jun 15, 2022):
In my case, I think this bug was my fault, not SuiteCRM. Double JS injection.
@joshscorpion do you still get this issue? Do you have any JS customizations? Any specific add-ons installed?
@joshscorpion commented on GitHub (Jun 15, 2022):
@pgorod I doubt this bug is your fault, its something within SuiteCRM that is triggering the double JS injection.
Even before I added the add-on from Dynamic Dropdown(Urdhva Tech) we already had this issue.
We were with SuiteCRM 7.11.15, not too stable, then moved to 7.11.17 and now on 7.11.18, which is working very reliably.
Our SuiteCRM 7.11.18 addresses many of the issues covered by 7.11.19.
Our PHP is v7.3 as SuiteCRM 7.11.18 is compatible max to PHP 7.3.