Favorites adds record twice to the sidebar and to the db #4513

Closed
opened 2026-02-20 16:18:39 -05:00 by deekerman · 4 comments
Owner

Originally created by @joshscorpion on GitHub (Apr 1, 2021).

Hi,

I am using SuiteCRM 7.11.18 and php 7.2, on Apache and Ubuntu.

The issue I have is that when I open an Account/Contact/etc and select it as a Favorite (by clicking the star next to the name) and I refresh the page, 2 Favorites (of the same link) are added to the sidebar.

When I go directly to the database, I see that indeed added 2 instances of the same Favorite, instead of only once as it should.

I've been looking through all the cases in this github, didn't find anyone else that reported the same issue.

Any ideas?

I am not a developer, any help is really appreciated.

Many thanks
Josh

Originally created by @joshscorpion on GitHub (Apr 1, 2021). Hi, I am using SuiteCRM 7.11.18 and php 7.2, on Apache and Ubuntu. The issue I have is that when I open an Account/Contact/etc and select it as a Favorite (by clicking the star next to the name) and I refresh the page, 2 Favorites (of the same link) are added to the sidebar. When I go directly to the database, I see that indeed added 2 instances of the same Favorite, instead of only once as it should. I've been looking through all the cases in this github, didn't find anyone else that reported the same issue. Any ideas? I am not a developer, any help is really appreciated. Many thanks Josh
Author
Owner

@SuiteBot commented on GitHub (Jun 13, 2022):

This issue has been mentioned on SuiteCRM. There might be relevant details there:

https://community.suitecrm.com/t/duplicate-links-for-favorited-contacts/81919/6

@SuiteBot commented on GitHub (Jun 13, 2022): This issue has been mentioned on **SuiteCRM**. There might be relevant details there: https://community.suitecrm.com/t/duplicate-links-for-favorited-contacts/81919/6
Author
Owner

@pgorod commented on GitHub (Jun 13, 2022):

This issue is related to JS events firing twice and it affects other things. Sometimes it only appears after loading a record through the Ajax mechanism (for example, entering a detail view form the Recently Viewed list on the sidebar).

I can see the Favorites creation requests doubled in the Network tab of the browser; and I can also see duplicate requests for inline editing when I double-click on a field.

My own code is also having trouble with this: JS code injected in AfterUI hook executes twice. So when I add an action button on top, sometimes I get two buttons...

There are probably other manifestations of this same bug which we're not seeing yet...

@pgorod commented on GitHub (Jun 13, 2022): This issue is related to JS events firing twice and it affects other things. Sometimes it only appears after loading a record through the Ajax mechanism (for example, entering a detail view form the Recently Viewed list on the sidebar). I can see the Favorites creation requests doubled in the Network tab of the browser; and I can also see duplicate requests for **inline editing** when I double-click on a field. My own code is also having trouble with this: JS code injected in AfterUI hook executes twice. So when I add an action button on top, sometimes I get two buttons... There are probably other manifestations of this same bug which we're not seeing yet...
Author
Owner

@pgorod commented on GitHub (Jun 15, 2022):

In my case, I think this bug was my fault, not SuiteCRM. Double JS injection.

@joshscorpion do you still get this issue? Do you have any JS customizations? Any specific add-ons installed?

@pgorod commented on GitHub (Jun 15, 2022): In my case, I think this bug was my fault, not SuiteCRM. Double JS injection. @joshscorpion do you still get this issue? Do you have any JS customizations? Any specific add-ons installed?
Author
Owner

@joshscorpion commented on GitHub (Jun 15, 2022):

@pgorod I doubt this bug is your fault, its something within SuiteCRM that is triggering the double JS injection.

Even before I added the add-on from Dynamic Dropdown(Urdhva Tech) we already had this issue.

We were with SuiteCRM 7.11.15, not too stable, then moved to 7.11.17 and now on 7.11.18, which is working very reliably.

Our SuiteCRM 7.11.18 addresses many of the issues covered by 7.11.19.

Our PHP is v7.3 as SuiteCRM 7.11.18 is compatible max to PHP 7.3.

@joshscorpion commented on GitHub (Jun 15, 2022): @pgorod I doubt this bug is your fault, its something within SuiteCRM that is triggering the double JS injection. Even before I added the add-on from Dynamic Dropdown(Urdhva Tech) we already had this issue. We were with SuiteCRM 7.11.15, not too stable, then moved to 7.11.17 and now on 7.11.18, which is working very reliably. Our SuiteCRM 7.11.18 addresses many of the issues covered by 7.11.19. Our PHP is v7.3 as SuiteCRM 7.11.18 is compatible max to PHP 7.3.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/SuiteCRM-SuiteCRM#4513
No description provided.