mirror of
https://github.com/SuiteCRM/SuiteCRM.git
synced 2026-03-02 19:16:58 -05:00
Cannot include custom TemplateHandler.php in upgrade safe way #4536
Labels
No labels
Area: API
Area: Campaigns
Area: Cases
Area: Clean Up
Area: Clean Up: Performance
Area: Dashlets
Area: Databases
Area: Developer Tools
Area: Elasticsearch
Area: Elasticsearch
Area: Emails
Area: Emails:Campaigns
Area: Emails:Cases
Area: Emails:Compose
Area: Emails:Config
Area: Emails:Templates
Area: Environment
Area: Installation
Area: Language
Area: Mobile
Area: Module
Area: PDFs
Area: PHP8
Area: Reports
Area: Studio
Area: Styling
Area: Upgrading
Area: Workflow
Area:Activity Stream
Area:Calls
Area:Import
Area:Projects
Area:Search
Area:Surveys
Area:Themes
Area:Users
Branch:Hotfix
Good First Issue
Hacktoberfest
Help Wanted
PR:Community Contribution
PR:Type:Enhancement
Priority:Critical
Priority:Important
Priority:Moderate
Severity: Major
Severity: Minor
Severity: Moderate
Status: Requires Code Review
Status: Requires Updates
Status: Stale
Status: Team Investigating
Status:Assessed
Status:Fix Proposed
Status:Needs Assessed
Status:Requires Automated Tests
Type: Bug
Type:Deprecated
Type:Discussion
Type:Duplicate
Type:Invalid
Type:Question
Type:Suggestion
Type:Suggestion
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/SuiteCRM-SuiteCRM#4536
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @wiatrp on GitHub (May 20, 2021).
Issue
I need a way to customize the
include/TemplateHandler/TemplateHandler.phpfile. This file is included/required in many other files with calls likerequire_once('include/TemplateHandler/TemplateHandler.php');orrequire_once 'include/TemplateHandler/TemplateHandler.php';. Because of this, I cannot create a custom file like what would be expected incustom/include/TemplateHandler/TemplateHandler.phpExpected Behavior
The
include/TemplateHandler/TemplateHandler.phpfile require calls should look for a custom file firstActual Behavior
The
include/TemplateHandler/TemplateHandler.phpfile require calls just grab the non custom filePossible Fix
Require once should be changed to search for custom files
Instead of:
require_once('include/TemplateHandler/TemplateHandler.php');Should be:
require_once(get_custom_file_if_exists('include/TemplateHandler/TemplateHandler.php'));Steps to Reproduce
TemplateHandler.phpto see all locations the file is usedContext
Your Environment