mirror of
https://github.com/SuiteCRM/SuiteCRM.git
synced 2026-03-02 19:16:58 -05:00
Country ISO List #4651
Labels
No labels
Area: API
Area: Campaigns
Area: Cases
Area: Clean Up
Area: Clean Up: Performance
Area: Dashlets
Area: Databases
Area: Developer Tools
Area: Elasticsearch
Area: Elasticsearch
Area: Emails
Area: Emails:Campaigns
Area: Emails:Cases
Area: Emails:Compose
Area: Emails:Config
Area: Emails:Templates
Area: Environment
Area: Installation
Area: Language
Area: Mobile
Area: Module
Area: PDFs
Area: PHP8
Area: Reports
Area: Studio
Area: Styling
Area: Upgrading
Area: Workflow
Area:Activity Stream
Area:Calls
Area:Import
Area:Projects
Area:Search
Area:Surveys
Area:Themes
Area:Users
Branch:Hotfix
Good First Issue
Hacktoberfest
Help Wanted
PR:Community Contribution
PR:Type:Enhancement
Priority:Critical
Priority:Important
Priority:Moderate
Severity: Major
Severity: Minor
Severity: Moderate
Status: Requires Code Review
Status: Requires Updates
Status: Stale
Status: Team Investigating
Status:Assessed
Status:Fix Proposed
Status:Needs Assessed
Status:Requires Automated Tests
Type: Bug
Type:Deprecated
Type:Discussion
Type:Duplicate
Type:Invalid
Type:Question
Type:Suggestion
Type:Suggestion
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/SuiteCRM-SuiteCRM#4651
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @tsmgeek on GitHub (Nov 8, 2021).
Originally assigned to: @samus-aran on GitHub.
github.com/salesagility/SuiteCRM@a4afbded55/include/language/en_us.lang.php (L2232)This country list does not follow ISO-3166-1, some countries like...
BOSNIA -> Bosnia and HerzegovinaVIETNAM -> Viet NamKOREA, SOUTH -> South KoreaorKorea, Republic ofKOREA -> North KoreaorKorea (Democratic People's Republic of),Problem is handling historical assignments.
Also all countries are uppercased, it would be better if this list was properly formatted.
I propose just changing the display names to their correct ones and leaving the internal keys as they are for now.
Even some of the translation packs are using the correct names, they just can not change the internal keys even though they are clearly wrong.
Mabey a migration to ISO codes being stored internally for any column that is a country name and just translate on display, internally a method to decode a country code to ISO2/ISO3/Short/Long names etc.
Some modules such as accounts always store the country name as entered, rather than ask user to select one from a list and then have consistency across the system.
ps. this has come to light as we post data in via the API for accounts and it does not validate the country name against the list, it will save whatever you supply.
https://en.wikipedia.org/wiki/ISO_3166-1