mirror of
https://github.com/SuiteCRM/SuiteCRM.git
synced 2026-03-02 19:16:58 -05:00
SuiteCRM Upgrade patches not including new elasticsearch logic hooks. #4782
Labels
No labels
Area: API
Area: Campaigns
Area: Cases
Area: Clean Up
Area: Clean Up: Performance
Area: Dashlets
Area: Databases
Area: Developer Tools
Area: Elasticsearch
Area: Elasticsearch
Area: Emails
Area: Emails:Campaigns
Area: Emails:Cases
Area: Emails:Compose
Area: Emails:Config
Area: Emails:Templates
Area: Environment
Area: Installation
Area: Language
Area: Mobile
Area: Module
Area: PDFs
Area: PHP8
Area: Reports
Area: Studio
Area: Styling
Area: Upgrading
Area: Workflow
Area:Activity Stream
Area:Calls
Area:Import
Area:Projects
Area:Search
Area:Surveys
Area:Themes
Area:Users
Branch:Hotfix
Good First Issue
Hacktoberfest
Help Wanted
PR:Community Contribution
PR:Type:Enhancement
Priority:Critical
Priority:Important
Priority:Moderate
Severity: Major
Severity: Minor
Severity: Moderate
Status: Requires Code Review
Status: Requires Updates
Status: Stale
Status: Team Investigating
Status:Assessed
Status:Fix Proposed
Status:Needs Assessed
Status:Requires Automated Tests
Type: Bug
Type:Deprecated
Type:Discussion
Type:Duplicate
Type:Invalid
Type:Question
Type:Suggestion
Type:Suggestion
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/SuiteCRM-SuiteCRM#4782
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ojs87 on GitHub (Jun 2, 2022).
Issue
When upgrading from, for example, 7.10.18 to 7.12.5, elastic search after_save and after_delete logic hooks are not added to the custom/modules/logic_hooks.php file, as they would be on a fresh install of suite 7.12.5.
Expected Behavior
The upgrade should include the logic hooks so when elastic search is enabled, saving a change to an indexed module will trigger a reindex.
Actual Behavior
Only the scheduled task or robo commands will reindex changes.
Possible Fix
Possibly add the install_es(install/suite_install/suite_install.php) or installESHooks(install/suite_install/Search.php) functions into the upgrade packages of suite versions before elastic search was added. Not sure how this is done with upgrade packages.
github.com/salesagility/SuiteCRM@51933421f7link to the commit for installing the hooksSteps to Reproduce
1.Start with a Suite v7.10.18 install
2.Use the upgrade wizard to upgrade to 7.12.5
3.build an elastic search server and enable elastic search in SuiteCRM, run a full index.
4.Ensure the elastic search scheduled task is not active so it does not run before step 5
5.Make a change to a record in any module and attempt to search for that change. The change should not appear in search results
Context
Upgrades from older Suite versions(pre elastic search) are not including the logic hooks so elastic search full functionality is not available.
Your Environment
@SuiteBot commented on GitHub (Apr 7, 2023):
This issue has been mentioned on SuiteCRM. There might be relevant details there:
https://community.suitecrm.com/t/elasticsearch-not-working-on-suitecrm-version-version-7-12-2/88677/2