mirror of
https://github.com/SuiteCRM/SuiteCRM.git
synced 2026-03-02 19:16:58 -05:00
Local images not imported in 7.12.6 #4796
Labels
No labels
Area: API
Area: Campaigns
Area: Cases
Area: Clean Up
Area: Clean Up: Performance
Area: Dashlets
Area: Databases
Area: Developer Tools
Area: Elasticsearch
Area: Elasticsearch
Area: Emails
Area: Emails:Campaigns
Area: Emails:Cases
Area: Emails:Compose
Area: Emails:Config
Area: Emails:Templates
Area: Environment
Area: Installation
Area: Language
Area: Mobile
Area: Module
Area: PDFs
Area: PHP8
Area: Reports
Area: Studio
Area: Styling
Area: Upgrading
Area: Workflow
Area:Activity Stream
Area:Calls
Area:Import
Area:Projects
Area:Search
Area:Surveys
Area:Themes
Area:Users
Branch:Hotfix
Good First Issue
Hacktoberfest
Help Wanted
PR:Community Contribution
PR:Type:Enhancement
Priority:Critical
Priority:Important
Priority:Moderate
Severity: Major
Severity: Minor
Severity: Moderate
Status: Requires Code Review
Status: Requires Updates
Status: Stale
Status: Team Investigating
Status:Assessed
Status:Fix Proposed
Status:Needs Assessed
Status:Requires Automated Tests
Type: Bug
Type:Deprecated
Type:Discussion
Type:Duplicate
Type:Invalid
Type:Question
Type:Suggestion
Type:Suggestion
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/SuiteCRM-SuiteCRM#4796
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @kunanSA on GitHub (Jul 6, 2022).
Issue
The email template cannot import image files, it can only use images from url
Expected Behavior
Import files from my computer
Actual Behavior
Since the Tinymce update, when wanting to import a local file. It is not possible, and it can only be done through the link
Environment
@samus-aran commented on GitHub (Jul 6, 2022):
Requires additional effort to re-instate local file upload e.g. https://www.tiny.cloud/docs/demo/file-picker/
@SinergiaCRM commented on GitHub (Jul 6, 2022):
Hi @samus-aran,
after updating to version 7.12.6 we have detected this same bug in mozaik. In version 7.12.4 TinyMCE did not offer this option but Mozaik did.
In version 7.12.4 we tried to implement the attach a local image button for tinyMCE but we didn't see how to achieve the same functionality as the attach images icon that appeared in mozaik. Consequently we created this issue: https://github.com/salesagility/SuiteCRM/issues/9586
The differences we saw between the functionality of mozaik and the implementation in tinyMCE were:
After that attempt, we thought that the button that appeared in Mozaik was not implemented through TinyMCE, but was added by SuiteCRM, although we were unable to locate how it was done.
If it has to be done through tinyMCE, could you give us some clue as to what we missed or how to implement it?
Thanks
@pgorod commented on GitHub (Jul 7, 2022):
@SinergiaCRM remember that Mozaik is just TinyMCE with some stuff on top.
The relevant code you're looking for might be this one:
https://github.com/salesagility/SuiteCRM/blob/master/modules/AOS_PDF_Templates/templateParser.php#L96-L112
... though you'll have to check, I am not sure
@SinergiaCRM commented on GitHub (May 10, 2023):
Thanks @pgorod, although we haven't figured out how to use that code to bring back the behavior from previous versions.
We still have the idea that the button that appeared in Mozaik was not implemented through TinyMCE. For now, we'll wait to see if the SuiteCRM team can bring the functionality back in mozaik and add it to tinyMCE.
@pgorod commented on GitHub (May 10, 2023):
Do you have access to an installation with the Mozaik that used to work? Can you see (browser dev tools, network tab) if there is a SuiteCRM request when you press the button to select a file, and tell me exactly what that request is?