mirror of
https://github.com/RandomNinjaAtk/arr-scripts.git
synced 2026-03-02 22:57:35 -05:00
[BUG] - Radarr+Sonarr - Scripts Reverting the quality settings #56
Labels
No labels
Needs Triage
Not Reproducible
Upstream Issue
User Error
bug
documentation
enhancement
good first issue
help wanted
invalid
lidarr
lidarr
question
radarr
readarr
sabnzbd
sonarr
synology (host)
unraid (host)
waiting for logs
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/arr-scripts#56
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @tommargar on GitHub (Sep 18, 2023).
Originally assigned to: @RandomNinjaAtk on GitHub.
Application
Radarr and Sonarr
Host platform
Docker
Script
Please identify which script your having a problem with...
Script Version
current
Describe the bug
Sonarr and Radarr always reset the quality settings to, I guess, the Arr scripts default.
It seems as if mainly the 1080 settings are affected. Every time I reset the values/edit them to my liking, it tales only half a day and everything's set the way it wasn't saved.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Keeping the quality settings as the user provided.
Logs/Screenshots
Radarr
Sonarr
@RandomNinjaAtk commented on GitHub (Sep 18, 2023):
If you have recyclarr enabled, that is what is changing it….
There is nothing to fix, and it’s not a bug, you just need to pay attention and understand your configuration…
@tommargar commented on GitHub (Sep 18, 2023):
Thank you, I'll take a look what Recyclarr tries to achieve. Otherwise, I'll turn it off for good.
@tommargar commented on GitHub (Sep 18, 2023):
Update: I've edited the recyclarr.yaml files and removed the quality definitions, as https://recyclarr.dev/wiki/yaml/config-reference/quality-definition/ stated those are optional.
Both Sonarr and Radarr keep re-adding those unwanted settings on restart of the docker container.
I think I skip Recyclarr entirely, as this is unusable ath the moment and leads to unwanted 20+ GB downloads.
/Edit: Disabled Recyclarr completely. When I was editing the yaml while initially setting everything up, I'm sure it wasn't there in the first place so I didn't care.
@RandomNinjaAtk commented on GitHub (Sep 18, 2023):
The recyclarr config file should not be getting reset on container restarts. Your customizations to the yaml file should stay intact... Is that not the case?
You can see where it is not to be overwritten (only downloads file if it does not already exist):
github.com/RandomNinjaAtk/arr-scripts@8b8f3bf844/radarr/setup.bash (L95-L98)github.com/RandomNinjaAtk/arr-scripts@8b8f3bf844/sonarr/setup.bash (L100-L104)@tommargar commented on GitHub (Sep 19, 2023):
Not sure what's happening. The yaml is being partially overwritten. The ip for the server stay intact, same as the API key.
But everytime I modify/delete the lines and restart any of the containers,
or
they get re-added.
/EDIT: Realized that this time also the IP address and API keys were overwritten.
I see the code and understand its purpose, but those files were overwritten nonetheless.
@RandomNinjaAtk commented on GitHub (Sep 19, 2023):
If you watch the container startup logs, you should see where it downloads the config files...
If it doesn't say "Download Recyclarr config...", then it isn't updating the file from online, so it shouldn't be overwriting changes. And if it is, then maybe there is a bug somewhere....
@RandomNinjaAtk commented on GitHub (Sep 19, 2023):
Your feedback did identify a problem, it should now be fixed. Apparently when I made it not overwrite the conf, I did some copy/pasta and didn't remove the original download/overwrite.
So it was always being overwritten. This should now be fixed going forward....
@tommargar commented on GitHub (Sep 19, 2023):
Thank you very much!