[Enhancement]: (Cosmetic) Lookup warning should not come up if difference is less than 2 seconds #2254

Open
opened 2026-02-20 02:14:10 -05:00 by deekerman · 0 comments
Owner

Originally created by @ZLoth on GitHub (Jul 5, 2024).

Type of Enhancement

Web Interface/Frontend

Describe the Feature/Enhancement

When the chapter lookup feature is used to retrieve chapter lists from audible, a comparison is done between what Audible lists as the book length and what the actual book length. Because of possible rounding errors, it is possible that a 1-2 second difference occurs between the local book length and the Audible book length. The difference causes a needed warning such as "Your audiobook duration is longer than the duration found" because of a 1 second difference.

Recording of issue: https://github.com/advplyr/audiobookshelf/assets/6700159/d06804c5-99e9-4043-b944-b814acfe66b8

Why would this be helpful?

This is an needless warning as 1 second error for a longer book could be considered within a margin of error. It should be displayed if there is a significant difference (e.g. 5 seconds)

Future Implementation (Screenshot)

image

Audiobookshelf Server Version

2.10.1

Current Implementation (Screenshot)

chrome 2024-07-05 10-48-11

Originally created by @ZLoth on GitHub (Jul 5, 2024). ### Type of Enhancement Web Interface/Frontend ### Describe the Feature/Enhancement When the chapter lookup feature is used to retrieve chapter lists from audible, a comparison is done between what Audible lists as the book length and what the actual book length. Because of possible rounding errors, it is possible that a 1-2 second difference occurs between the local book length and the Audible book length. The difference causes a needed warning such as "Your audiobook duration is longer than the duration found" because of a 1 second difference. Recording of issue: https://github.com/advplyr/audiobookshelf/assets/6700159/d06804c5-99e9-4043-b944-b814acfe66b8 ### Why would this be helpful? This is an needless warning as 1 second error for a longer book could be considered within a margin of error. It should be displayed if there is a significant difference (e.g. 5 seconds) ### Future Implementation (Screenshot) ![image](https://github.com/advplyr/audiobookshelf/assets/6700159/c8cc14d5-6eea-433c-8016-0b71c9473031) ### Audiobookshelf Server Version 2.10.1 ### Current Implementation (Screenshot) ![chrome 2024-07-05 10-48-11](https://github.com/advplyr/audiobookshelf/assets/6700159/a623a376-77be-4838-ae75-3499f82756d8)
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/audiobookshelf#2254
No description provided.