mirror of
https://github.com/advplyr/audiobookshelf.git
synced 2026-03-02 22:46:56 -05:00
[Enhancement]: (Cosmetic) Lookup warning should not come up if difference is less than 2 seconds #2254
Labels
No labels
authentication
awaiting release
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/audiobookshelf#2254
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ZLoth on GitHub (Jul 5, 2024).
Type of Enhancement
Web Interface/Frontend
Describe the Feature/Enhancement
When the chapter lookup feature is used to retrieve chapter lists from audible, a comparison is done between what Audible lists as the book length and what the actual book length. Because of possible rounding errors, it is possible that a 1-2 second difference occurs between the local book length and the Audible book length. The difference causes a needed warning such as "Your audiobook duration is longer than the duration found" because of a 1 second difference.
Recording of issue: https://github.com/advplyr/audiobookshelf/assets/6700159/d06804c5-99e9-4043-b944-b814acfe66b8
Why would this be helpful?
This is an needless warning as 1 second error for a longer book could be considered within a margin of error. It should be displayed if there is a significant difference (e.g. 5 seconds)
Future Implementation (Screenshot)
Audiobookshelf Server Version
2.10.1
Current Implementation (Screenshot)