Orientation enum #1031

Closed
opened 2026-02-20 00:01:18 -05:00 by deekerman · 1 comment
Owner

Originally created by @brighteyed on GitHub (Jun 29, 2023).

Originally assigned to: @jrasm91 on GitHub.

Based on discussion in #3003.

  • Since exiftool-vendored disables the print conversion for the Orientation tag, I believe that guarantees we can get only 1-8 values for the orientation of photos.
  • ffprobe returns other values for the orientation (-90, 90, etc.)

We can change the type of the orientation field in ExifEntity and ExifResponseDto to enum to provide a better experience for all the clients.

Originally created by @brighteyed on GitHub (Jun 29, 2023). Originally assigned to: @jrasm91 on GitHub. Based on discussion in #3003. * Since `exiftool-vendored` disables the print conversion for the Orientation tag, I believe that guarantees we can get only `1-8` values for the orientation of photos. * `ffprobe` returns other values for the orientation (`-90`, `90`, etc.) We can change the type of the orientation field in `ExifEntity` and `ExifResponseDto` to enum to provide a better experience for all the clients.
Author
Owner

@uhthomas commented on GitHub (Jun 30, 2023):

Be aware that #2908 will use exiftool for all media types and as such, the values will always be 1-8.

@uhthomas commented on GitHub (Jun 30, 2023): Be aware that #2908 will use exiftool for all media types and as such, the values will always be 1-8.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/immich#1031
No description provided.