starred/kvm
1
0
Fork 0
mirror of https://github.com/jetkvm/kvm.git synced 2026-03-02 22:58:00 -05:00
Code Issues 252 Projects Packages Wiki Activity

Question about the codebase. Should we be returning here? #405

New issue
Closed
opened 2026-02-20 08:22:30 -05:00 by deekerman · 0 comments
deekerman commented 2026-02-20 08:22:30 -05:00
Owner
Copy link

Originally created by @alexballas on GitHub (Sep 11, 2025).

Originally assigned to: @ym on GitHub.

https://github.com/jetkvm/kvm/blame/ea068414dccf8d52400164dd1ea8c10d305756ad/display.go#L166

Should we be returning here? It feels that if we run startCloudBlink and cloudBlinkStopped is false we're just going to spawn more goroutines.

@ym

Originally created by @alexballas on GitHub (Sep 11, 2025). Originally assigned to: @ym on GitHub. https://github.com/jetkvm/kvm/blame/ea068414dccf8d52400164dd1ea8c10d305756ad/display.go#L166 Should we be returning here? It feels that if we run `startCloudBlink` and `cloudBlinkStopped` is false we're just going to spawn more goroutines. @ym
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
dev
dependabot/npm_and_yarn/ui/vitejs/plugin-react-swc-4.2.3
dependabot/npm_and_yarn/ui/vite-tsconfig-paths-6.1.1
dependabot/npm_and_yarn/ui/framer-motion-12.34.3
dependabot/npm_and_yarn/ui/tailwind-merge-3.5.0
dependabot/npm_and_yarn/ui/multi-d88693a43a
dependabot/go_modules/github.com/pion/webrtc/v4-4.2.9
dependabot/npm_and_yarn/ui/inlang/cli-3.1.6
dependabot/npm_and_yarn/ui/eslint-plugin-react-refresh-0.5.2
dependabot/go_modules/golang.org/x/sys-0.41.0
dependabot/go_modules/golang.org/x/crypto-0.48.0
dependabot/npm_and_yarn/ui/zustand-5.0.11
dependabot/go_modules/github.com/prometheus/procfs-0.20.1
dependabot/npm_and_yarn/ui/inlang/sdk-2.7.0
dependabot/go_modules/github.com/gin-gonic/gin-1.12.0
dependabot/go_modules/golang.org/x/net-0.51.0
dependabot/github_actions/actions/upload-artifact-7
dependabot/npm_and_yarn/ui/npm_and_yarn-e66adb831b
feat/signed-releases
dependabot/go_modules/github.com/prometheus/common-0.67.5
fix/ipv6-readiness
fix/failsafe-tolerance
fix/failscafe-tolerance
debug/native-logs
fix/retry-sleep-mode-check
copilot/add-copilot-instructions-file
chore/es-lint-redux
fix/deploy-cloud-app
release-cloud-app/0.4.9
release-cloud-app/0.4.8
release-cloud-app/0.4.5
release-cloud-app/0.4.4
release-cloud-app/0.4.3
release-cloud-app/0.4.2
release-cloud-app/0.4.1
release-cloud-app/0.4.0
release-cloud-app/0.3.9
release-cloud-app/0.3.8
fix/prevent-video-restart-loop
fix/en-as-default
backports/ota-und-cgo
e2e-tests
release/049
feat/audio-support-metrics
fix/usb-gadget-init-rebind
feat/lldp
feat/usb-reset
feat/audio-support
fix/hdmi-mutex
main
feat/auto-reload-fe
feat/jsonrpc-typings
feat/ocr
chore/show-codec
chore/golangci-lint-additional
refactor/jsonrpc-kbd
misc/0.4.6-with-old-deps
feat/static-ip-ui
cursor/refactor-uselocation-to-prevent-re-renders-f026
cursor/remove-uselocation-from-devices-id-tsx-7751
chore/eslint-prettier-setup
feat/tls-config
feat/metrics-optin
feat/tls
release/0.5.4-dev202602080922
release/0.5.3
release/0.5.3-dev202602061404
release/0.5.3-dev202601281951
release/0.5.2-dev202601071426
release/0.5.2
release/0.5.2-dev202601070105
release/0.5.2-dev202601070032
release/0.5.2-dev202601061215
release/0.5.2-dev202601051816
release/0.5.2-dev202512291946
release/0.5.1-dev202512211114
release/0.5.1
release/0.5.1-dev202512181840
release/0.5.1-dev202512181609
release/0.5.1-dev202512181144
release/0.5.0-dev202512051510
release/0.5.0
0.5.0-dev202511271013
0.5.0-dev202511271020
release/0.5.0-dev202511211223
release/0.5.0-dev20251120
release/0.4.9
release/0.4.8
release/0.4.7
challenge-base
release/0.4.6
release/0.4.5
release/0.4.5-rc2
release/0.4.5-rc1
release/0.4.4
release/0.4.3
release/0.4.2
release/0.4.1
release/0.4.0
release/0.3.9
release/0.3.8
Labels
Clear labels   
component/keyboard-layout

   
component: cloud

   
component: device screen

   
component: extensions

   
component: hid/keyboard

   
component: hid/mouse

   
component: network

   
component: timesync

   
component: ui

   
component: updater

   
component: usb

   
component: usb/hid

   
component: usb/storage

   
component: video

   
component: webrtc

   
component: webserver

   
need-more-details

   
status: working-in-progress

   
wontfix
No labels
component/keyboard-layout
component: cloud
component: device screen
component: extensions
component: hid/keyboard
component: hid/mouse
component: network
component: timesync
component: ui
component: updater
component: usb
component: usb/hid
component: usb/storage
component: video
component: webrtc
component: webserver
need-more-details
status: working-in-progress
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/kvm#405
No description provided.