Do not call fdisk for listing disks in container #2184

New issue

Open

opened 2026-02-28 01:06:40 -05:00 by deekerman · 0 comments

deekerman commented

2026-02-28 01:06:40 -05:00

Owner

Originally created by @MichaIng on GitHub (Apr 9, 2022).

Done here: github.com/motioneye-project/motioneye@16fd474/motioneye/controls/diskctl.py (L157-L164)
Within a container there is no point in doing this since a container has no access to the physical disks anyway. We could either add a check for whether we are in a container, or we could simply check for which fdisk/command -v fdisk, assuming that it is only installed when physical disk access is possible at all.

Originally created by @MichaIng on GitHub (Apr 9, 2022). Done here: https://github.com/motioneye-project/motioneye/blob/16fd474/motioneye/controls/diskctl.py#L157-L164 Within a container there is no point in doing this since a container has no access to the physical disks anyway. We could either add a check for whether we are in a container, or we could simply check for `which fdisk`/`command -v fdisk`, assuming that it is only installed when physical disk access is possible at all.

deekerman added the

enhancement

docker

labels

2026-02-28 01:06:40 -05:00

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/motioneye#2184

No description provided.

Rows
Columns