mirror of
https://github.com/mumble-voip/mumble.git
synced 2026-03-03 00:46:56 -05:00
Add non-global shortcuts #1751
Labels
No labels
GlobalShortcuts
Hacktoberfest
accessibility
acl
asio
audio
bonjour
bsd
bug
build
certificate
ci
client
code
documentation
external-bug
feature-request
gRPC
github
good first issue
help wanted
help-needed
ice
installer
linux
macOS
needs-ckeck-with-latest-version
needs-more-input
overlay
positional audio
priority/P0 - Blocker
priority/P1 - Critical
priority/P2 - Important
priority/P3 - Somewhat important
priority/P4 - Low
public-server-registration
qt
recording
release-management
server
stale-no-response
stale-support
support
task
test
theme
translation
triage
ui
windows
wontfix
x64
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/mumble-mumble-voip#1751
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @xorbug on GitHub (Mar 20, 2020).
Hi all,
so, mumble is able to catch the PTT button even when its window is not focused. This is by design, and is exactly what everyone wants in order to communicate while doing something else (i.e. interacting with softwares running in different windows).
The downside of this behaviour is that if a very common key is bound to the PTT function, you find yourself toggling your mic on/off when it's not needed, maybe transmitting some unwanted sounds and/or causing annoyance to other mumble users. Imagine what happens when setting the PTT key to space and you go in another window to edit some text.
At the moment it seems the easy workarounds are:
The main obvious problem with these approaches is that the key you like the most can not be set. Setting a different one, forces you into using a less convenient shortcut. Using the PTT window also breaks the appearance (by spawning a new window) and may force the use of mouse (in order to click or just move the cursor inside it to press space).
I think some users may want to not give up on their favourite and easy keybinding for PTT, yet limiting its detection to the mumble window only in order to avoid unwanted activations.
So, considering all this, maybe an option to enable PTT only when the mumble client window is focused can be handy for some users. If it's not hard to implement it may be worth it.
Thanks to all the developers and contributors.
@Krzmbrzl commented on GitHub (Mar 21, 2020):
I took the liberty of changing your issue's title as I think if we implement this, we shouldn't aim for providing this kind of functionality for PTT only. I think we should simply add a way to add shortcuts that are non-global, meaning that they can only be triggered if Mumble has focus.